2022-04-12 22:07:37

by Li Zhijian

Subject: [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state()

wqe was not used by update_state() so far.

aaaf62e06623 ("RDMA/rxe: Remove useless argument for update_state()")
just did a partial fixes.

Signed-off-by: Li Zhijian <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 5f7348b11268..bf7493bab9b9 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -525,8 +525,7 @@ static void rollback_state(struct rxe_send_wqe *wqe,
qp->req.psn = rollback_psn;
}

-static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
- struct rxe_pkt_info *pkt)
+static void update_state(struct rxe_qp *qp, struct rxe_pkt_info *pkt)
{
qp->req.opcode = pkt->opcode;

@@ -753,7 +752,7 @@ int rxe_requester(void *arg)
goto err;
}

- update_state(qp, wqe, &pkt);
+ update_state(qp, &pkt);

goto next_wqe;

--
2.31.1

2022-04-22 17:24:34

by Li Zhijian

Subject: Re: [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state()

ping


On 12/04/2022 10:29, Li Zhijian wrote:
> wqe was not used by update_state() so far.
>
> aaaf62e06623 ("RDMA/rxe: Remove useless argument for update_state()")
> just did a partial fixes.
>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 5f7348b11268..bf7493bab9b9 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -525,8 +525,7 @@ static void rollback_state(struct rxe_send_wqe *wqe,
> qp->req.psn = rollback_psn;
> }
>
> -static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
> - struct rxe_pkt_info *pkt)
> +static void update_state(struct rxe_qp *qp, struct rxe_pkt_info *pkt)
> {
> qp->req.opcode = pkt->opcode;
>
> @@ -753,7 +752,7 @@ int rxe_requester(void *arg)
> goto err;
> }
>
> - update_state(qp, wqe, &pkt);
> + update_state(qp, &pkt);
>
> goto next_wqe;
>

2022-04-23 01:21:57

by Jason Gunthorpe

Subject: Re: [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state()

On Fri, Apr 22, 2022 at 01:07:46AM +0000, [email protected] wrote:
> ping

I'd like to see some of the people testing rxe look over these, at
least until we get rxe back to being stable

Jason

2022-04-26 09:15:15

by Jason Gunthorpe

Subject: Re: [PATCH 1/3] RDMA/rxe: Remove useless parameters for update_state()

On Tue, Apr 12, 2022 at 10:29:01AM +0800, Li Zhijian wrote:
> wqe was not used by update_state() so far.
>
> aaaf62e06623 ("RDMA/rxe: Remove useless argument for update_state()")
> just did a partial fixes.
>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

I applied just this patch to for-next

Thanks,
Jason