2022-04-25 07:32:14

by Icenowy Zheng

Subject: [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical

RTC itself is the one and only consumer of rtc-32k clock. As the rtc
should be always running, set rtc-32k clock to critical, to prevent it
from being gated by the kernel.

Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
Signed-off-by: Icenowy Zheng <[email protected]>
---
drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
index 8a10bade7e0d..3d9c9ce5a3db 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
@@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
.ops = &ccu_mux_ops,
.parent_hws = rtc_32k_parents,
.num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated during probe */
+ .flags = CLK_IS_CRITICAL,
};

static struct ccu_mux rtc_32k_clk = {
--
2.35.1

2022-04-25 08:16:11

by Jernej Škrabec

Subject: Re: [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical

Dne nedelja, 24. april 2022 ob 07:59:59 CEST je Icenowy Zheng napisal(a):
> RTC itself is the one and only consumer of rtc-32k clock. As the rtc
> should be always running, set rtc-32k clock to critical, to prevent it
> from being gated by the kernel.
>
> Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
> Signed-off-by: Icenowy Zheng <[email protected]>

This one was already submitted here:
https://lore.kernel.org/linux-sunxi/[email protected]/

Best regards,
Jernej

> ---
> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-
sun6i-rtc.c
> index 8a10bade7e0d..3d9c9ce5a3db 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> @@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
> .ops = &ccu_mux_ops,
> .parent_hws = rtc_32k_parents,
> .num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated
during probe */
> + .flags = CLK_IS_CRITICAL,
> };
>
> static struct ccu_mux rtc_32k_clk = {
> --
> 2.35.1
>
>
>