2022-04-24 17:28:43

by CGEL

[permalink] [raw]
Subject: [PATCH] scsi: bfa: remove unneeded flush_workqueue

From: ran jianping <[email protected]>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/scsi/bfa/bfad_im.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
index 8419a1a89485..c335f7a188d2 100644
--- a/drivers/scsi/bfa/bfad_im.c
+++ b/drivers/scsi/bfa/bfad_im.c
@@ -755,7 +755,6 @@ void
bfad_destroy_workq(struct bfad_im_s *im)
{
if (im && im->drv_workq) {
- flush_workqueue(im->drv_workq);
destroy_workqueue(im->drv_workq);
im->drv_workq = NULL;
}
--
2.25.1


2022-05-04 02:19:48

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: bfa: remove unneeded flush_workqueue

On Sun, 24 Apr 2022 06:18:45 +0000, [email protected] wrote:

> From: ran jianping <[email protected]>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: bfa: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/4c0df601e150

--
Martin K. Petersen Oracle Linux Engineering