2022-04-25 07:20:50

by CGEL

[permalink] [raw]
Subject: [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue

From: ran jianping <[email protected]>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/scsi/qla2xxx/qla_os.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 762229d495a8..73073fb08369 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3933,7 +3933,6 @@ qla2x00_free_device(scsi_qla_host_t *vha)

/* Flush the work queue and remove it */
if (ha->wq) {
- flush_workqueue(ha->wq);
destroy_workqueue(ha->wq);
ha->wq = NULL;
}
--
2.25.1


2022-05-04 10:16:35

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: qla2xxx: remove unneeded flush_workqueue

On Sun, 24 Apr 2022 06:24:13 +0000, [email protected] wrote:

> From: ran jianping <[email protected]>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: qla2xxx: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/cf97628fe1a1

--
Martin K. Petersen Oracle Linux Engineering