2022-04-24 14:25:40

by CGEL

Subject: [PATCH] scsi:fnic: remove unneeded flush_workqueue

From: ran jianping <[email protected]>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/scsi/fnic/fnic_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index 9161bd2fd421..460e03a55096 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -1146,10 +1146,8 @@ static void __exit fnic_cleanup_module(void)
{
pci_unregister_driver(&fnic_driver);
destroy_workqueue(fnic_event_queue);
- if (fnic_fip_queue) {
- flush_workqueue(fnic_fip_queue);
+ if (fnic_fip_queue)
destroy_workqueue(fnic_fip_queue);
- }
kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_MAX]);
kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]);
kmem_cache_destroy(fnic_io_req_cache);
--
2.25.1

2022-05-04 09:51:26

by Martin K. Petersen

Subject: Re: [PATCH] scsi:fnic: remove unneeded flush_workqueue

On Sun, 24 Apr 2022 06:54:06 +0000, [email protected] wrote:

> From: ran jianping <[email protected]>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
>

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi:fnic: remove unneeded flush_workqueue
https://git.kernel.org/mkp/scsi/c/671a52f2aeaf

--
Martin K. Petersen Oracle Linux Engineering