2022-04-25 01:04:16

by Yassine Oudjana

[permalink] [raw]
Subject: [PATCH v2 0/3] dt-bindings: arm: mediatek: Convert some docs to DT schema

From: Yassine Oudjana <[email protected]>

This series includes DT schema conversions for topckgen, apmixedsys
and infracfg bindings.

Changes since v1:
- Move mediatek,topckgen.yaml and mediatek,apmixedsys.yaml to ../bindings/clock/
- Remove items from first enums in topckgen and apmixedsys schemas
- Mention headers with clock and reset values in all schema descriptions
- Add clock framework maintainers to topckgen and apmixedsys schemas
- Rename node name in infracfg example to clock-controller

Yassine Oudjana (3):
dt-bindings: arm: mediatek: topckgen: Convert to DT schema
dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema
dt-bindings: arm: mediatek: infracfg: Convert to DT schema

.../arm/mediatek/mediatek,apmixedsys.txt | 35 --------
.../arm/mediatek/mediatek,infracfg.txt | 42 ----------
.../arm/mediatek/mediatek,infracfg.yaml | 81 +++++++++++++++++++
.../arm/mediatek/mediatek,topckgen.txt | 35 --------
.../bindings/clock/mediatek,apmixedsys.yaml | 61 ++++++++++++++
.../bindings/clock/mediatek,topckgen.yaml | 61 ++++++++++++++
6 files changed, 203 insertions(+), 112 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt
create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.yaml
delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt
create mode 100644 Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml
create mode 100644 Documentation/devicetree/bindings/clock/mediatek,topckgen.yaml

--
2.36.0


2022-04-25 07:56:21

by Yassine Oudjana

[permalink] [raw]
Subject: [PATCH v2 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema

From: Yassine Oudjana <[email protected]>

Convert apmixedsys bindings to DT schema format. MT2701, MT7623 and
MT7629 device trees currently have the syscon compatible without
it being mentioned in the old DT bindings file which introduces
dtbs_check errors when converting to DT schema as-is, so
mediatek,mt2701-apmixedsys and mediatek,mt7629-apmixedsys are placed
in the last items list with the syscon compatible, and syscon is
added to the mediatek,mt7623-apmixedsys list.

Signed-off-by: Yassine Oudjana <[email protected]>
---
.../arm/mediatek/mediatek,apmixedsys.txt | 35 -----------
.../bindings/clock/mediatek,apmixedsys.yaml | 61 +++++++++++++++++++
2 files changed, 61 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
create mode 100644 Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
deleted file mode 100644
index 3fa755866528..000000000000
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Mediatek apmixedsys controller
-==============================
-
-The Mediatek apmixedsys controller provides the PLLs to the system.
-
-Required Properties:
-
-- compatible: Should be one of:
- - "mediatek,mt2701-apmixedsys"
- - "mediatek,mt2712-apmixedsys", "syscon"
- - "mediatek,mt6765-apmixedsys", "syscon"
- - "mediatek,mt6779-apmixedsys", "syscon"
- - "mediatek,mt6797-apmixedsys"
- - "mediatek,mt7622-apmixedsys"
- - "mediatek,mt7623-apmixedsys", "mediatek,mt2701-apmixedsys"
- - "mediatek,mt7629-apmixedsys"
- - "mediatek,mt7986-apmixedsys"
- - "mediatek,mt8135-apmixedsys"
- - "mediatek,mt8167-apmixedsys", "syscon"
- - "mediatek,mt8173-apmixedsys"
- - "mediatek,mt8183-apmixedsys", "syscon"
- - "mediatek,mt8516-apmixedsys"
-- #clock-cells: Must be 1
-
-The apmixedsys controller uses the common clk binding from
-Documentation/devicetree/bindings/clock/clock-bindings.txt
-The available clocks are defined in dt-bindings/clock/mt*-clk.h.
-
-Example:
-
-apmixedsys: clock-controller@10209000 {
- compatible = "mediatek,mt8173-apmixedsys";
- reg = <0 0x10209000 0 0x1000>;
- #clock-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml b/Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml
new file mode 100644
index 000000000000..770546195fb5
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/clock/mediatek,apmixedsys.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MediaTek AP Mixedsys Controller
+
+maintainers:
+ - Michael Turquette <[email protected]>
+ - Stephen Boyd <[email protected]>
+
+description:
+ The Mediatek apmixedsys controller provides PLLs to the system.
+ The clock values can be found in <dt-bindings/clock/mt*-clk.h>.
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - mediatek,mt6797-apmixedsys
+ - mediatek,mt7622-apmixedsys
+ - mediatek,mt7986-apmixedsys
+ - mediatek,mt8135-apmixedsys
+ - mediatek,mt8173-apmixedsys
+ - mediatek,mt8516-apmixedsys
+ - items:
+ - const: mediatek,mt7623-apmixedsys
+ - const: mediatek,mt2701-apmixedsys
+ - const: syscon
+ - items:
+ - enum:
+ - mediatek,mt2701-apmixedsys
+ - mediatek,mt2712-apmixedsys
+ - mediatek,mt6765-apmixedsys
+ - mediatek,mt6779-apmixedsys
+ - mediatek,mt7629-apmixedsys
+ - mediatek,mt8167-apmixedsys
+ - mediatek,mt8183-apmixedsys
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ apmixedsys: clock-controller@10209000 {
+ compatible = "mediatek,mt8173-apmixedsys";
+ reg = <0x10209000 0x1000>;
+ #clock-cells = <1>;
+ };
--
2.36.0

2022-04-25 17:50:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema

On 24/04/2022 10:46, Yassine Oudjana wrote:
> From: Yassine Oudjana <[email protected]>
>
> Convert apmixedsys bindings to DT schema format. MT2701, MT7623 and
> MT7629 device trees currently have the syscon compatible without
> it being mentioned in the old DT bindings file which introduces
> dtbs_check errors when converting to DT schema as-is, so
> mediatek,mt2701-apmixedsys and mediatek,mt7629-apmixedsys are placed
> in the last items list with the syscon compatible, and syscon is
> added to the mediatek,mt7623-apmixedsys list.
>
> Signed-off-by: Yassine Oudjana <[email protected]>
> ---
> .../arm/mediatek/mediatek,apmixedsys.txt | 35 -----------
> .../bindings/clock/mediatek,apmixedsys.yaml | 61 +++++++++++++++++++
> 2 files changed, 61 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
> create mode 100644 Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-04-27 09:09:55

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: apmixedsys: Convert to DT schema

On Sun, 24 Apr 2022 12:46:46 +0400, Yassine Oudjana wrote:
> From: Yassine Oudjana <[email protected]>
>
> Convert apmixedsys bindings to DT schema format. MT2701, MT7623 and
> MT7629 device trees currently have the syscon compatible without
> it being mentioned in the old DT bindings file which introduces
> dtbs_check errors when converting to DT schema as-is, so
> mediatek,mt2701-apmixedsys and mediatek,mt7629-apmixedsys are placed
> in the last items list with the syscon compatible, and syscon is
> added to the mediatek,mt7623-apmixedsys list.
>
> Signed-off-by: Yassine Oudjana <[email protected]>
> ---
> .../arm/mediatek/mediatek,apmixedsys.txt | 35 -----------
> .../bindings/clock/mediatek,apmixedsys.yaml | 61 +++++++++++++++++++
> 2 files changed, 61 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
> create mode 100644 Documentation/devicetree/bindings/clock/mediatek,apmixedsys.yaml
>

Applied, thanks!