2022-04-25 07:07:31

by David Heidelberg

Subject: [PATCH v2 1/3] dt-bindings: net: qcom,ipa: fix example for upcomming smp2p conversion

Example of mpss was missing required properties.

Signed-off-by: David Heidelberg <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 58ecc62adfaa..852658b4d05c 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -182,6 +182,11 @@ examples:

smp2p-mpss {
compatible = "qcom,smp2p";
+ mboxes = <&apss_shared 14>;
+ qcom,smem = <435>, <428>;
+ qcom,local-pid = <0>;
+ qcom,remote-pid = <1>;
+
ipa_smp2p_out: ipa-ap-to-modem {
qcom,entry-name = "ipa";
#qcom,smem-state-cells = <1>;
--
2.35.1

2022-04-25 10:50:33

by David Heidelberg

Subject: [PATCH v2 2/3] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

These missing required properties are needed for
smp2p binding reference checks.

Misc: adjusted examples properties formatting from dtsi.

Signed-off-by: David Heidelberg <[email protected]>
---
.../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index 866efb278813..d573d555f4c6 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -75,9 +75,14 @@ examples:

smp2p-modem {
compatible = "qcom,smp2p";
- interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
- IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
- mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
+ qcom,smem = <443>, <429>;
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_SMP2P>;

+ qcom,local-pid = <0>;
+ qcom,remote-pid = <2>;
/* Other SMP2P fields */
};
--
2.35.1

2022-04-25 14:20:01

by Rob Herring (Arm)

Subject: Re: [PATCH v2 2/3] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

On Sun, 24 Apr 2022 15:15:20 +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
>
> Misc: adjusted examples properties formatting from dtsi.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> .../devicetree/bindings/mailbox/qcom-ipcc.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/


mailbox@ed18000: compatible:0: 'qcom,sm8450-ipcc' is not one of ['qcom,sm6350-ipcc', 'qcom,sm8250-ipcc', 'qcom,sm8350-ipcc', 'qcom,sc7280-ipcc']
arch/arm64/boot/dts/qcom/sm8450-hdk.dtb
arch/arm64/boot/dts/qcom/sm8450-qrd.dtb