2022-04-25 07:05:21

by Bean Huo

Subject: [PATCH v3 6/6] scsi: ufshpb: Cleanup ufshpb_suspend/resume

From: Bean Huo <[email protected]>

ufshpb_resume() is only called when the HPB state is HPB_SUSPEND, so
the check statement for "ufshpb_get_state(hpb) != HPB_PRESENT" is useless.

Signed-off-by: Bean Huo <[email protected]>
---
drivers/scsi/ufs/ufshpb.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 7868412054bf..10f40e390dc5 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -2349,11 +2349,9 @@ void ufshpb_suspend(struct ufs_hba *hba)

shost_for_each_device(sdev, hba->host) {
hpb = ufshpb_get_hpb_data(sdev);
- if (!hpb)
+ if (!hpb || ufshpb_get_state(hpb) != HPB_PRESENT)
continue;

- if (ufshpb_get_state(hpb) != HPB_PRESENT)
- continue;
ufshpb_set_state(hpb, HPB_SUSPEND);
ufshpb_cancel_jobs(hpb);
}
@@ -2366,20 +2364,15 @@ void ufshpb_resume(struct ufs_hba *hba)

shost_for_each_device(sdev, hba->host) {
hpb = ufshpb_get_hpb_data(sdev);
- if (!hpb)
+ if (!hpb || ufshpb_get_state(hpb) != HPB_SUSPEND)
continue;

- if ((ufshpb_get_state(hpb) != HPB_PRESENT) &&
- (ufshpb_get_state(hpb) != HPB_SUSPEND))
- continue;
ufshpb_set_state(hpb, HPB_PRESENT);
ufshpb_kick_map_work(hpb);
if (hpb->is_hcm) {
- unsigned int poll =
- hpb->params.timeout_polling_interval_ms;
+ unsigned int poll = hpb->params.timeout_polling_interval_ms;

- schedule_delayed_work(&hpb->ufshpb_read_to_work,
- msecs_to_jiffies(poll));
+ schedule_delayed_work(&hpb->ufshpb_read_to_work, msecs_to_jiffies(poll));
}
}
}
--
2.34.1

2022-04-26 20:40:57

by Keoseong Park

Subject: RE: [PATCH v3 6/6] scsi: ufshpb: Cleanup ufshpb_suspend/resume

>From: Bean Huo <[email protected]>
>
>ufshpb_resume() is only called when the HPB state is HPB_SUSPEND, so
>the check statement for "ufshpb_get_state(hpb) != HPB_PRESENT" is useless.
>
>Signed-off-by: Bean Huo <[email protected]>
Reviewed-by: Keoseong Park <[email protected]>

Best Regards,
Keoseong Park

>---
> drivers/scsi/ufs/ufshpb.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
>index 7868412054bf..10f40e390dc5 100644
>--- a/drivers/scsi/ufs/ufshpb.c
>+++ b/drivers/scsi/ufs/ufshpb.c
>@@ -2349,11 +2349,9 @@ void ufshpb_suspend(struct ufs_hba *hba)
>
> shost_for_each_device(sdev, hba->host) {
> hpb = ufshpb_get_hpb_data(sdev);
>- if (!hpb)
>+ if (!hpb || ufshpb_get_state(hpb) != HPB_PRESENT)
> continue;
>
>- if (ufshpb_get_state(hpb) != HPB_PRESENT)
>- continue;
> ufshpb_set_state(hpb, HPB_SUSPEND);
> ufshpb_cancel_jobs(hpb);
> }
>@@ -2366,20 +2364,15 @@ void ufshpb_resume(struct ufs_hba *hba)
>
> shost_for_each_device(sdev, hba->host) {
> hpb = ufshpb_get_hpb_data(sdev);
>- if (!hpb)
>+ if (!hpb || ufshpb_get_state(hpb) != HPB_SUSPEND)
> continue;
>
>- if ((ufshpb_get_state(hpb) != HPB_PRESENT) &&
>- (ufshpb_get_state(hpb) != HPB_SUSPEND))
>- continue;
> ufshpb_set_state(hpb, HPB_PRESENT);
> ufshpb_kick_map_work(hpb);
> if (hpb->is_hcm) {
>- unsigned int poll =
>- hpb->params.timeout_polling_interval_ms;
>+ unsigned int poll = hpb->params.timeout_polling_interval_ms;
>
>- schedule_delayed_work(&hpb->ufshpb_read_to_work,
>- msecs_to_jiffies(poll));
>+ schedule_delayed_work(&hpb->ufshpb_read_to_work, msecs_to_jiffies(poll));
> }
> }
> }
>--
>2.34.1
>
>