2022-04-25 12:54:03

by Camel Guo

Subject: [PATCH] hwmon: (tmp401) Fix incorrect return value of tmp401_init_client

When ti,n-factor, ti,beta-compentation are not defined in devicetree,
of_property_read_u32|s32 returns -EINVAL. In this case,
tmp401_init_client should return 0 instead of simply pass ret to its
caller.

Fixes: c825ca044988 ("hwmon: (tmp401) Add support of three advanced features")
Signed-off-by: Camel Guo <[email protected]>
---
drivers/hwmon/tmp401.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index 8f49da997367..a58a2f31a07e 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401.c
@@ -604,7 +604,7 @@ static int tmp401_init_client(struct tmp401_data *data)
return ret;
}

- return ret;
+ return 0;
}

static int tmp401_detect(struct i2c_client *client,
--
2.30.2

2022-04-26 00:50:21

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (tmp401) Fix incorrect return value of tmp401_init_client

On Mon, Apr 25, 2022 at 12:00:19PM +0200, Camel Guo wrote:
> When ti,n-factor, ti,beta-compentation are not defined in devicetree,
> of_property_read_u32|s32 returns -EINVAL. In this case,
> tmp401_init_client should return 0 instead of simply pass ret to its
> caller.
>
> Fixes: c825ca044988 ("hwmon: (tmp401) Add support of three advanced features")
> Signed-off-by: Camel Guo <[email protected]>

Good catch. Thanks, applied.

Guenter

> ---
> drivers/hwmon/tmp401.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
> index 8f49da997367..a58a2f31a07e 100644
> --- a/drivers/hwmon/tmp401.c
> +++ b/drivers/hwmon/tmp401.c
> @@ -604,7 +604,7 @@ static int tmp401_init_client(struct tmp401_data *data)
> return ret;
> }
>
> - return ret;
> + return 0;
> }
>
> static int tmp401_detect(struct i2c_client *client,