2022-04-26 09:34:00

by CGEL

Subject: [PATCH] mmc: block: use kobj_to_dev()

From: Minghao Chi <[email protected]>

Use kobj_to_dev() instead of open-coding it.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/mmc/core/block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index b35e7a95798b..983151b7296d 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -330,7 +330,7 @@ static struct attribute *mmc_disk_attrs[] = {
static umode_t mmc_disk_attrs_is_visible(struct kobject *kobj,
struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
umode_t mode = a->mode;

--
2.25.1

2022-05-05 08:30:33

by Ulf Hansson

Subject: Re: [PATCH] mmc: block: use kobj_to_dev()

On Mon, 25 Apr 2022 at 12:53, <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Use kobj_to_dev() instead of open-coding it.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/core/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index b35e7a95798b..983151b7296d 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -330,7 +330,7 @@ static struct attribute *mmc_disk_attrs[] = {
> static umode_t mmc_disk_attrs_is_visible(struct kobject *kobj,
> struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
> umode_t mode = a->mode;
>
> --
> 2.25.1
>
>