2022-04-25 18:49:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

On 25/04/2022 15:28, Oleksij Rempel wrote:
> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
> communication.
>
> - PRTT1C - 10BaseT1L switch
> - PRTT1S - 10BaseT1L CO2 sensor board
> - PRTT1A - 10BaseT1L multi functional controller
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof


2022-04-25 23:56:48

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
> On 25/04/2022 15:28, Oleksij Rempel wrote:
>> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
>> communication.
>>
>> - PRTT1C - 10BaseT1L switch
>> - PRTT1S - 10BaseT1L CO2 sensor board
>> - PRTT1A - 10BaseT1L multi functional controller
>>
>> Signed-off-by: Oleksij Rempel <[email protected]>
>> ---
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>

Although the order is still messed up. I through you will move the entry
just slightly up, not to the beginning, so maybe just rebase on top of:
https://lore.kernel.org/all/[email protected]/


Best regards,
Krzysztof

2022-04-26 14:12:18

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

On Mon, Apr 25, 2022 at 04:06:45PM +0200, Krzysztof Kozlowski wrote:
> On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
> > On 25/04/2022 15:28, Oleksij Rempel wrote:
> >> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
> >> communication.
> >>
> >> - PRTT1C - 10BaseT1L switch
> >> - PRTT1S - 10BaseT1L CO2 sensor board
> >> - PRTT1A - 10BaseT1L multi functional controller
> >>
> >> Signed-off-by: Oleksij Rempel <[email protected]>
> >> ---
> >
> >
> > Acked-by: Krzysztof Kozlowski <[email protected]>
>
> Although the order is still messed up. I through you will move the entry
> just slightly up, not to the beginning, so maybe just rebase on top of:
> https://lore.kernel.org/all/[email protected]/

I put it according to the SoC version. st,stm32mp151 would be the first
entry before stm32mp153. What order do you prefer, where should I put my
boards?

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |