2022-04-26 09:08:55

by Guo Zhengkui

Subject: [PATCH linux-next] RDMA/hns: fix returnvar.cocci warning

Fix the following coccicheck warning:
drivers/infiniband/hw/hns/hns_roce_mr.c:343:5-8: Unneeded variable: "ret".
Return "0" on line 351.

Signed-off-by: Guo Zhengkui <[email protected]>
---
drivers/infiniband/hw/hns/hns_roce_mr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
index b389738d157f..867972c2a894 100644
--- a/drivers/infiniband/hw/hns/hns_roce_mr.c
+++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
@@ -340,7 +340,6 @@ int hns_roce_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)
{
struct hns_roce_dev *hr_dev = to_hr_dev(ibmr->device);
struct hns_roce_mr *mr = to_hr_mr(ibmr);
- int ret = 0;

if (hr_dev->hw->dereg_mr)
hr_dev->hw->dereg_mr(hr_dev);
@@ -348,7 +347,7 @@ int hns_roce_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)
hns_roce_mr_free(hr_dev, mr);
kfree(mr);

- return ret;
+ return 0;
}

struct ib_mr *hns_roce_alloc_mr(struct ib_pd *pd, enum ib_mr_type mr_type,
--
2.20.1

2022-05-08 19:19:39

by Jason Gunthorpe

Subject: Re: [PATCH linux-next] RDMA/hns: fix returnvar.cocci warning

On Tue, Apr 26, 2022 at 03:08:58PM +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/infiniband/hw/hns/hns_roce_mr.c:343:5-8: Unneeded variable: "ret".
> Return "0" on line 351.
>
> Signed-off-by: Guo Zhengkui <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_mr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason