2022-04-27 09:33:20

by Akhil R

Subject: [PATCH v2 0/2] Fix uninitialized variable usage in Tegra GPCDMA

Initialize uninitialized variable and remove unused switch case
in tegra186-gpcdma driver.

v1->v2: Split the patches to separate 'fixes'.

Akhil R (2):
dmaengine: tegra: Fix uninitialized variable usage
dmaengine: tegra: Remove unused switch case

drivers/dma/tegra186-gpc-dma.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

--
2.17.1

2022-04-27 10:54:04

by Akhil R

Subject: [PATCH v2 1/2] dmaengine: tegra: Fix uninitialized variable usage

Initialize slave_bw in dma_prep*() functions as the parameter is not
set for DMA_MEM_TO_MEM case in get_transfer_param(). Though the case
may never occur, initializing it avoids warning from certain static
checkers

Fixes: ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Akhil R <[email protected]>
---
drivers/dma/tegra186-gpc-dma.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
index f12327732041..a0dbafa07ec9 100644
--- a/drivers/dma/tegra186-gpc-dma.c
+++ b/drivers/dma/tegra186-gpc-dma.c
@@ -985,8 +985,8 @@ tegra_dma_prep_slave_sg(struct dma_chan *dc, struct scatterlist *sgl,
{
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
unsigned int max_dma_count = tdc->tdma->chip_data->max_dma_count;
+ enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0;
- enum dma_slave_buswidth slave_bw;
struct tegra_dma_sg_req *sg_req;
struct tegra_dma_desc *dma_desc;
struct scatterlist *sg;
@@ -1103,12 +1103,12 @@ tegra_dma_prep_dma_cyclic(struct dma_chan *dc, dma_addr_t buf_addr, size_t buf_l
size_t period_len, enum dma_transfer_direction direction,
unsigned long flags)
{
+ enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
+ u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
+ unsigned int max_dma_count, len, period_count, i;
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
struct tegra_dma_desc *dma_desc;
struct tegra_dma_sg_req *sg_req;
- enum dma_slave_buswidth slave_bw;
- u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
- unsigned int max_dma_count, len, period_count, i;
dma_addr_t mem = buf_addr;
int ret;

--
2.17.1

2022-05-20 22:00:01

by Vinod Koul

Subject: Re: [PATCH v2 0/2] Fix uninitialized variable usage in Tegra GPCDMA

On 26-04-22, 15:49, Akhil R wrote:
> Initialize uninitialized variable and remove unused switch case
> in tegra186-gpcdma driver.

Applied, thanks

--
~Vinod