2022-04-27 09:05:56

by Mattijs Korpershoek

Subject: [PATCH] pinctrl: mediatek: mt8365: fix IES control pins

IES26 (BIT 16 of IES1_CFG_ADDR) controls the following pads:

- PAD_I2S_DATA_IN (GPIO114)
- PAD_I2S_LRCK (GPIO115)
- PAD_I2S_BCK (GPIO116)

The pinctrl table is wrong since it lists pins 114 to 112.

Update the table with the correct values.

Fixes: e94d8b6fb83a ("pinctrl: mediatek: add support for mt8365 SoC")
Reported-by: Youngmin Han <[email protected]>
Signed-off-by: Mattijs Korpershoek <[email protected]>
---
drivers/pinctrl/mediatek/pinctrl-mt8365.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8365.c b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
index 727c65221aef..57f37a294063 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8365.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
@@ -259,7 +259,7 @@ static const struct mtk_pin_ies_smt_set mt8365_ies_set[] = {
MTK_PIN_IES_SMT_SPEC(104, 104, 0x420, 13),
MTK_PIN_IES_SMT_SPEC(105, 109, 0x420, 14),
MTK_PIN_IES_SMT_SPEC(110, 113, 0x420, 15),
- MTK_PIN_IES_SMT_SPEC(114, 112, 0x420, 16),
+ MTK_PIN_IES_SMT_SPEC(114, 116, 0x420, 16),
MTK_PIN_IES_SMT_SPEC(117, 119, 0x420, 17),
MTK_PIN_IES_SMT_SPEC(120, 122, 0x420, 18),
MTK_PIN_IES_SMT_SPEC(123, 125, 0x420, 19),
--
2.32.0

2022-04-29 21:02:04

by Linus Walleij

Subject: Re: [PATCH] pinctrl: mediatek: mt8365: fix IES control pins

On Tue, Apr 26, 2022 at 2:57 PM Mattijs Korpershoek
<[email protected]> wrote:

> IES26 (BIT 16 of IES1_CFG_ADDR) controls the following pads:
>
> - PAD_I2S_DATA_IN (GPIO114)
> - PAD_I2S_LRCK (GPIO115)
> - PAD_I2S_BCK (GPIO116)
>
> The pinctrl table is wrong since it lists pins 114 to 112.
>
> Update the table with the correct values.
>
> Fixes: e94d8b6fb83a ("pinctrl: mediatek: add support for mt8365 SoC")
> Reported-by: Youngmin Han <[email protected]>
> Signed-off-by: Mattijs Korpershoek <[email protected]>

Patch applied for fixes.

Yours,
Linus Walleij