2022-04-27 06:56:37

by Bard Liao

Subject: [PATCH 1/5] soundwire: qcom: return error when pm_runtime_get_sync fails

From: Pierre-Louis Bossart <[email protected]>

For some reason there's a missing error return in two places.

Fixes: 74e79da9fd46a ("soundwire: qcom: add runtime pm support")
Fixes: 04d46a7b38375 ("soundwire: qcom: add in-band wake up interrupt support")
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Péter Ujfalusi <[email protected]>
Signed-off-by: Bard Liao <[email protected]>
---
drivers/soundwire/qcom.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index f5fc8c27012a..c40c25f2d264 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id)
"pm_runtime_get_sync failed in %s, ret %d\n",
__func__, ret);
pm_runtime_put_noidle(swrm->dev);
+ return ret;
}

if (swrm->wake_irq > 0) {
@@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file *s_file, void *data)
"pm_runtime_get_sync failed in %s, ret %d\n",
__func__, ret);
pm_runtime_put_noidle(swrm->dev);
+ return ret;
}

for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {
--
2.25.1

2022-04-29 23:56:27

by Srinivas Kandagatla

Subject: Re: [PATCH 1/5] soundwire: qcom: return error when pm_runtime_get_sync fails

On 27/04/2022 00:56, Bard Liao wrote:
> From: Pierre-Louis Bossart <[email protected]>
>
> For some reason there's a missing error return in two places.
>
> Fixes: 74e79da9fd46a ("soundwire: qcom: add runtime pm support")
> Fixes: 04d46a7b38375 ("soundwire: qcom: add in-band wake up interrupt support")
> Signed-off-by: Pierre-Louis Bossart <[email protected]>
> Reviewed-by: Péter Ujfalusi <[email protected]>
> Signed-off-by: Bard Liao <[email protected]>
> ---

Reviewed-by: Srinivas Kandagatla <[email protected]>

> drivers/soundwire/qcom.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index f5fc8c27012a..c40c25f2d264 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -516,6 +516,7 @@ static irqreturn_t qcom_swrm_wake_irq_handler(int irq, void *dev_id)
> "pm_runtime_get_sync failed in %s, ret %d\n",
> __func__, ret);
> pm_runtime_put_noidle(swrm->dev);
> + return ret;
> }
>
> if (swrm->wake_irq > 0) {
> @@ -1258,6 +1259,7 @@ static int swrm_reg_show(struct seq_file *s_file, void *data)
> "pm_runtime_get_sync failed in %s, ret %d\n",
> __func__, ret);
> pm_runtime_put_noidle(swrm->dev);
> + return ret;
> }
>
> for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {