Hi all,
After merging the input tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_output':
drivers/input/touchscreen/goodix.c:624:12: error: implicit declaration of function 'acpi_execute_simple_method' [-Werror=implicit-function-declaration]
624 | status = acpi_execute_simple_method(ACPI_HANDLE(dev),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/goodix.c:606:17: warning: unused variable 'dev' [-Wunused-variable]
606 | struct device *dev = &ts->client->dev;
| ^~~
drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_input':
drivers/input/touchscreen/goodix.c:634:17: warning: unused variable 'dev' [-Wunused-variable]
634 | struct device *dev = &ts->client->dev;
| ^~~
cc1: some warnings being treated as errors
Caused by commit
c5fca485320e ("Input: goodix - add support for controlling the IRQ pin through ACPI methods")
I have applied the following patch for today:
From: Stephen Rothwell <[email protected]>
Date: Wed, 25 Mar 2020 18:04:08 +1100
Subject: [PATCH] Input: goodix - mark as BROKEN for noe
Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index c071f7c407b6..98788fb83917 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -380,6 +380,7 @@ config TOUCHSCREEN_GOODIX
tristate "Goodix I2C touchscreen"
depends on I2C
depends on GPIOLIB || COMPILE_TEST
+ depends on BROKEN
help
Say Y here if you have the Goodix touchscreen (such as one
installed in Onda v975w tablets) connected to your
--
2.25.0
--
Cheers,
Stephen Rothwell
Hi all,
On Wed, 25 Mar 2020 18:16:00 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the input tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_output':
> drivers/input/touchscreen/goodix.c:624:12: error: implicit declaration of function 'acpi_execute_simple_method' [-Werror=implicit-function-declaration]
> 624 | status = acpi_execute_simple_method(ACPI_HANDLE(dev),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/input/touchscreen/goodix.c:606:17: warning: unused variable 'dev' [-Wunused-variable]
> 606 | struct device *dev = &ts->client->dev;
> | ^~~
> drivers/input/touchscreen/goodix.c: In function 'goodix_irq_direction_input':
> drivers/input/touchscreen/goodix.c:634:17: warning: unused variable 'dev' [-Wunused-variable]
> 634 | struct device *dev = &ts->client->dev;
> | ^~~
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> c5fca485320e ("Input: goodix - add support for controlling the IRQ pin through ACPI methods")
>
> I have applied the following patch for today:
>
> From: Stephen Rothwell <[email protected]>
> Date: Wed, 25 Mar 2020 18:04:08 +1100
> Subject: [PATCH] Input: goodix - mark as BROKEN for noe
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/input/touchscreen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index c071f7c407b6..98788fb83917 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -380,6 +380,7 @@ config TOUCHSCREEN_GOODIX
> tristate "Goodix I2C touchscreen"
> depends on I2C
> depends on GPIOLIB || COMPILE_TEST
> + depends on BROKEN
> help
> Say Y here if you have the Goodix touchscreen (such as one
> installed in Onda v975w tablets) connected to your
I am still marking this as BROKEN ...
--
Cheers,
Stephen Rothwell
On Wed, Apr 27, 2022 at 08:35:25AM +0100, Lee Jones wrote:
> On Wed, 27 Apr 2022, Fabien Parent wrote:
>
> > Hi,
> >
> > On Wed, Apr 27, 2022 at 10:48:25AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the input tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/input/keyboard/mtk-pmic-keys.c:93:36: error: 'MT6359_TOPSTATUS' undeclared here (not in a function); did you mean 'MT6358_TOPSTATUS'?
> > > 93 | MTK_PMIC_KEYS_REGS(MT6359_TOPSTATUS,
> > > | ^~~~~~~~~~~~~~~~
> > > drivers/input/keyboard/mtk-pmic-keys.c:48:35: note: in definition of macro 'MTK_PMIC_KEYS_REGS'
> > > 48 | .deb_reg = _deb_reg, \
> > > | ^~~~~~~~
> > > drivers/input/keyboard/mtk-pmic-keys.c:98:25: error: 'MT6359_TOP_RST_MISC' undeclared here (not in a function); did you mean 'MT6358_TOP_RST_MISC'?
> > > 98 | .pmic_rst_reg = MT6359_TOP_RST_MISC,
> > > | ^~~~~~~~~~~~~~~~~~~
> > > | MT6358_TOP_RST_MISC
> > >
> > > Caused by commit
> > >
> > > 0f97adf64314 ("Input: mtk-pmic-keys - add support for MT6359")
> > >
> > > I have used the input tree from next-20220426 for today.
> >
> > The commit is depending on another commit from the same patch serie: [0]. That
> > patch has been merged in the tree of the MFD maintainer: [1].
> >
> > [0] https://lore.kernel.org/all/[email protected]/
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next
>
> Looks like you only sent me 2 of the 8 patches in the set.
>
> In future, if there are dependencies between patches, you must send
> all of the patches to everyone. That way, we can organise a merge
> strategy that does not break -next, or worse Mainline during the
> merge-window.
Understood. Thanks for the info, I will make sure next time to include
everyone in such situation.
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog