2022-04-27 10:48:56

by Nishanth Menon

Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm

On 21:05-20220426, Rahul T R wrote:
> From: Tomi Valkeinen <[email protected]>
>

[...]

>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 2f119e94e783..4b9e3f671781 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -148,6 +148,28 @@
> pinctrl-0 = <&main_mcan2_gpio_pins_default>;
> standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>;
> };
> +
> + dp_pwr_3v3: regulator-dp-prw {

See feedback in https://lore.kernel.org/all/[email protected]/

> + compatible = "regulator-fixed";
> + regulator-name = "dp-pwr";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&exp4 0 GPIO_ACTIVE_HIGH>; /* P0 - DP0_PWR_SW_EN */
> + enable-active-high;
> + };
> +
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2022-04-27 14:55:54

by Rahul T R

Subject: Re: [PATCH v4 2/2] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm

On 13:13-20220426, Nishanth Menon wrote:
> On 21:05-20220426, Rahul T R wrote:
> > From: Tomi Valkeinen <[email protected]>
> >
>
> [...]
>
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> > index 2f119e94e783..4b9e3f671781 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> > @@ -148,6 +148,28 @@
> > pinctrl-0 = <&main_mcan2_gpio_pins_default>;
> > standby-gpios = <&main_gpio0 127 GPIO_ACTIVE_HIGH>;
> > };
> > +
> > + dp_pwr_3v3: regulator-dp-prw {
>
> See feedback in https://lore.kernel.org/all/[email protected]/

Hi Nishanth,

As per the feedback in the above thread
the name matches with below convention
"regulator-foo-bar" or "foo-bar-regulator"

Are you referring to the typo here?
regulator-dp-prw => regulator-dp-pwr
will fix this in the respin

Can you please clarify if you there is
any issue other than the typo

Regards
Rahul T R

>
> > + compatible = "regulator-fixed";
> > + regulator-name = "dp-pwr";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpio = <&exp4 0 GPIO_ACTIVE_HIGH>; /* P0 - DP0_PWR_SW_EN */
> > + enable-active-high;
> > + };
> > +
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D