2022-04-27 15:34:42

by Vitaly Rodionov

Subject: [PATCH 19/26] ALSA: cs35l41: Do not print error when waking from hibernation

From: Stefan Binding <[email protected]>

When waking from hibernation, it is possible for the function
which sends the wake command to fail initially, but after a
retry it will succeed. There is no need to print an error if
the initial attempts fail.

Signed-off-by: Stefan Binding <[email protected]>
Signed-off-by: Vitaly Rodionov <[email protected]>
---
sound/soc/codecs/cs35l41-lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l41-lib.c b/sound/soc/codecs/cs35l41-lib.c
index dc4654f43157..8a796dbe0718 100644
--- a/sound/soc/codecs/cs35l41-lib.c
+++ b/sound/soc/codecs/cs35l41-lib.c
@@ -1300,7 +1300,8 @@ int cs35l41_set_cspl_mbox_cmd(struct device *dev, struct regmap *regmap,
return 0;
}

- dev_err(dev, "Failed to set mailbox cmd %u (status %u)\n", cmd, sts);
+ if (cmd != CSPL_MBOX_CMD_OUT_OF_HIBERNATE)
+ dev_err(dev, "Failed to set mailbox cmd %u (status %u)\n", cmd, sts);

return -ENOMSG;
}
--
2.32.0

2022-04-28 12:41:28

by Charles Keepax

Subject: Re: [PATCH 19/26] ALSA: cs35l41: Do not print error when waking from hibernation

On Wed, Apr 27, 2022 at 04:07:13PM +0100, Vitaly Rodionov wrote:
> From: Stefan Binding <[email protected]>
>
> When waking from hibernation, it is possible for the function
> which sends the wake command to fail initially, but after a
> retry it will succeed. There is no need to print an error if
> the initial attempts fail.
>
> Signed-off-by: Stefan Binding <[email protected]>
> Signed-off-by: Vitaly Rodionov <[email protected]>
> ---

Commit message should be ASoC: not ALSA:, but otherwise looks
good.

Thanks,
Charles