2022-04-27 19:44:04

by Caleb Connolly

[permalink] [raw]
Subject: [PATCH 0/6] power: supply: introduce support for the Qualcomm smb2 charger

Add a driver for the Qualcomm PMI8998/PM660 Switch-Mode Battery Charger.
This is the second generation SMB charger, and replaces the previous
SMBB hardware found in older PMICs.

This driver provides basic support for initialising the hardware,
configuring the USB input current limit and reporting information about
the state of the charger. Features like type-c dual role support and OTG
switching will be added in future patches.

This patch series depends on my previous series adding support for
the Round Robin ADC which is used for reading the USB voltage and
current, it can be found here:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes since v1:
* Rename the driver to pmi8998_charger
* Drop unnecessary (and very broken) mutex
* Rework the driver based on feedback to v1
* Fix some minor bugs and improve Automatic Input Current Limit support

---
Caleb Connolly (6):
power: supply: add Qualcomm PMI8998 SMB2 Charger driver
arm64: dts: qcom: pmi8998: add charger node
arm64: dts: sdm845-oneplus: enable pmi8998 charger
arm64: dts: qcom: sdm845-db845c: enable pmi8998 charger
arm64: dts: qcom: sdm845-xiaomi-beryllium enable pmi8998 charger
dt-bindings: power: supply: qcom,pmi8998-charger: add bindings for
smb2 driver

.../power/supply/qcom,pmi8998-charger.yaml | 83 ++
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 17 +
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 18 +
.../boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 +
.../dts/qcom/sdm845-oneplus-enchilada.dts | 4 +
.../boot/dts/qcom/sdm845-oneplus-fajita.dts | 4 +
.../boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 13 +
drivers/power/supply/Kconfig | 9 +
drivers/power/supply/Makefile | 1 +
drivers/power/supply/qcom_pmi8998_charger.c | 1070 +++++++++++++++++
10 files changed, 1223 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
create mode 100644 drivers/power/supply/qcom_pmi8998_charger.c

--
2.36.0


2022-04-27 20:53:18

by Caleb Connolly

[permalink] [raw]
Subject: [PATCH 2/6] arm64: dts: qcom: pmi8998: add charger node

Add a node for the smb2 charger hardware found on the pmi8998.

Signed-off-by: Caleb Connolly <[email protected]>
---
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index da10668c361d..962a8719b07a 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -9,6 +9,23 @@ pmi8998_lsid0: pmic@2 {
#address-cells = <1>;
#size-cells = <0>;

+ pmi8998_charger: charger@1000 {
+ compatible = "qcom,pmi8998-charger";
+ reg = <0x1000>;
+
+ interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>,
+ <0x2 0x12 0x2 IRQ_TYPE_EDGE_BOTH>,
+ <0x2 0x16 0x1 IRQ_TYPE_EDGE_RISING>,
+ <0x2 0x13 0x6 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "usb-plugin", "bat-ov", "wdog-bark", "usbin-icl-change";
+
+ io-channels = <&pmi8998_rradc 3>,
+ <&pmi8998_rradc 4>;
+ io-channel-names = "usbin_i", "usbin_v";
+
+ status = "disabled";
+ };
+
pmi8998_gpio: gpios@c000 {
compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
--
2.36.0

2022-05-09 09:24:29

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 0/6] power: supply: introduce support for the Qualcomm smb2 charger

Hi!

> Add a driver for the Qualcomm PMI8998/PM660 Switch-Mode Battery Charger.
> This is the second generation SMB charger, and replaces the previous
> SMBB hardware found in older PMICs.
>
> This driver provides basic support for initialising the hardware,
> configuring the USB input current limit and reporting information about
> the state of the charger. Features like type-c dual role support and OTG
> switching will be added in future patches.
>
> This patch series depends on my previous series adding support for
> the Round Robin ADC which is used for reading the USB voltage and
> current, it can be found here:
> https://lore.kernel.org/linux-arm-msm/[email protected]/

Please cc phone-devel mailing list with this and related stuff.

Best regards,
Pavel