+CC lkml
On 04/28/22 15:43, Qais Yousef wrote:
> From: Dietmar Eggemann <[email protected]>
>
> cfs_rq_tg_path() is used by a tracepoint-to traceevent (tp-2-te)
> converter to format the path of a taskgroup or autogroup respectively.
> It doesn't have any in-kernel users after the removal of the
> sched_trace_cfs_rq_path() helper function.
>
> cfs_rq_tg_path() can be coded in a tp-2-te converter.
>
> Remove it from kernel/sched/fair.c.
>
> Signed-off-by: Dietmar Eggemann <[email protected]>
> Signed-off-by: Qais Yousef <[email protected]>
> ---
> kernel/sched/fair.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index ff1177a4a286..7487737c1275 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -313,19 +313,6 @@ const struct sched_class fair_sched_class;
> #define for_each_sched_entity(se) \
> for (; se; se = se->parent)
>
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> - if (!path)
> - return;
> -
> - if (cfs_rq && task_group_is_autogroup(cfs_rq->tg))
> - autogroup_path(cfs_rq->tg, path, len);
> - else if (cfs_rq && cfs_rq->tg->css.cgroup)
> - cgroup_path(cfs_rq->tg->css.cgroup, path, len);
> - else
> - strlcpy(path, "(null)", len);
> -}
> -
> static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> {
> struct rq *rq = rq_of(cfs_rq);
> @@ -493,12 +480,6 @@ static int se_is_idle(struct sched_entity *se)
> #define for_each_sched_entity(se) \
> for (; se; se = NULL)
>
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> - if (path)
> - strlcpy(path, "(null)", len);
> -}
> -
> static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> {
> return true;
> --
> 2.25.1
>