2022-04-29 12:39:26

by CGEL

Subject: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()

From: Minghao Chi <[email protected]>

Simplify the return expression.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
index eea719243eaf..10c6b3e492d3 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
@@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss,
{
struct dss_pll *pll = &hpll->pll;
struct clk *clk;
- int r;

clk = devm_clk_get(&pdev->dev, "sys_clk");
if (IS_ERR(clk)) {
@@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss,

pll->ops = &hdmi_pll_ops;

- r = dss_pll_register(dss, pll);
- if (r)
- return r;
-
- return 0;
+ return dss_pll_register(dss, pll);
}

int hdmi_pll_init(struct dss_device *dss, struct platform_device *pdev,
--
2.25.1

2022-04-29 15:55:17

by Tomi Valkeinen

Subject: Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()

On 29/04/2022 12:01, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> index eea719243eaf..10c6b3e492d3 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> @@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss,
> {
> struct dss_pll *pll = &hpll->pll;
> struct clk *clk;
> - int r;
>
> clk = devm_clk_get(&pdev->dev, "sys_clk");
> if (IS_ERR(clk)) {
> @@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss,
>
> pll->ops = &hdmi_pll_ops;
>
> - r = dss_pll_register(dss, pll);
> - if (r)
> - return r;
> -
> - return 0;
> + return dss_pll_register(dss, pll);
> }

This is a rather pointless change, and I personally like the current
style better.

Tomi