2022-04-29 21:19:13

by Niklas Schnelle

[permalink] [raw]
Subject: [RFC v2 16/39] leds: add HAS_IOPORT dependencies

In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to add HAS_IOPORT as dependency for
those drivers using them.

Co-developed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Niklas Schnelle <[email protected]>
---
drivers/leds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 6090e647daee..d05b7b035b13 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -681,7 +681,7 @@ config LEDS_LM355x

config LEDS_OT200
tristate "LED support for the Bachmann OT200"
- depends on LEDS_CLASS && HAS_IOMEM && (X86_32 || COMPILE_TEST)
+ depends on LEDS_CLASS && HAS_IOPORT && (X86_32 || COMPILE_TEST)
help
This option enables support for the LEDs on the Bachmann OT200.
Say Y to enable LEDs on the Bachmann OT200.
--
2.32.0


2022-05-02 23:41:20

by Niklas Schnelle

[permalink] [raw]
Subject: Re: [RFC v2 16/39] leds: add HAS_IOPORT dependencies

On Fri, 2022-04-29 at 20:54 +0200, Pavel Machek wrote:
> Hi!
>
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. We thus need to add HAS_IOPORT as dependency for
> > those drivers using them.
> >
> > Co-developed-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Niklas Schnelle <[email protected]>
>
> I don't see a problem there.
>
> Acked-by: Pavel Machek <[email protected]>
>
> (Its marked RFC so I'm not taking the patch.. right?)
>
> Best regards,
> Pavel

Right and thank you.

2022-05-03 01:09:00

by Pavel Machek

[permalink] [raw]
Subject: Re: [RFC v2 16/39] leds: add HAS_IOPORT dependencies

Hi!

> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
>
> Co-developed-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Niklas Schnelle <[email protected]>

I don't see a problem there.

Acked-by: Pavel Machek <[email protected]>

(Its marked RFC so I'm not taking the patch.. right?)

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.


Attachments:
(No filename) (531.00 B)
signature.asc (201.00 B)
Download all attachments