2022-04-30 08:05:00

by Nícolas F. R. A. Prado

Subject: Re: [PATCH v8 2/2] arm64: dts: Add MediaTek SoC MT8186 dts and evaluation board and Makefile

Hi Allen,

On Thu, Apr 28, 2022 at 02:17:17PM +0800, Allen-KH Cheng wrote:
> + scp: scp@10500000 {
> + compatible = "mediatek,mt8186-scp";
> + reg = <0 0x10500000 0 0x40000>,
> + <0 0x105c0000 0 0x19080>;
> + reg-names = "sram", "cfg";

The mtk,scp dt-binding should be updated as it currently doesn't allow l1tcm to
be missing. According to comments in the driver cfg is optional as well, so a
patch to the binding making both optional would be great.

Thanks,
N?colas

2022-05-03 00:04:32

by Nícolas F. R. A. Prado

Subject: Re: [PATCH v8 2/2] arm64: dts: Add MediaTek SoC MT8186 dts and evaluation board and Makefile

On Thu, Apr 28, 2022 at 01:27:41PM -0400, N?colas F. R. A. Prado wrote:
> Hi Allen,
>
> On Thu, Apr 28, 2022 at 02:17:17PM +0800, Allen-KH Cheng wrote:
> > + scp: scp@10500000 {
> > + compatible = "mediatek,mt8186-scp";
> > + reg = <0 0x10500000 0 0x40000>,
> > + <0 0x105c0000 0 0x19080>;
> > + reg-names = "sram", "cfg";
>
> The mtk,scp dt-binding should be updated as it currently doesn't allow l1tcm to
> be missing. According to comments in the driver cfg is optional as well, so a
> patch to the binding making both optional would be great.

Hi Allen,

actually I've just sent a patch for this myself [1], as it was also required for
mt8192-asurada. Sorry for the noise.

Thanks,
N?colas

[1] https://lore.kernel.org/all/[email protected]/

>
> Thanks,
> N?colas