2022-03-23 12:10:47

by Chris Packham

Subject: [PATCH v3 1/3] dt-bindings: hwmon: Document adt7475 pin-function properties

The adt7473, adt7475, adt7476 and adt7490 have pins that can be used for
different functions. Add bindings so that it is possible to describe
what pin functions are intended by the hardware design.

Signed-off-by: Chris Packham <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---

Notes:
Changes in v3:
- None
Changes in v2:
- Add review from Krzysztof

.../devicetree/bindings/hwmon/adt7475.yaml | 22 +++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
index 7d9c083632b9..22beb37f1bf1 100644
--- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
+++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
@@ -61,6 +61,26 @@ patternProperties:
$ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1]

+ "adi,pin(5|10)-function":
+ description: |
+ Configures the function for pin 5 on the adi,adt7473 and adi,adt7475. Or
+ pin 10 on the adi,adt7476 and adi,adt7490.
+ $ref: /schemas/types.yaml#/definitions/string
+ enum:
+ - pwm2
+ - smbalert#
+
+ "adi,pin(9|14)-function":
+ description: |
+ Configures the function for pin 9 on the adi,adt7473 and adi,adt7475. Or
+ pin 14 on the adi,adt7476 and adi,adt7490
+ $ref: /schemas/types.yaml#/definitions/string
+ enum:
+ - tach4
+ - therm#
+ - smbalert#
+ - gpio
+
required:
- compatible
- reg
@@ -79,6 +99,8 @@ examples:
adi,bypass-attenuator-in0 = <1>;
adi,bypass-attenuator-in1 = <0>;
adi,pwm-active-state = <1 0 1>;
+ adi,pin10-function = "smbalert#";
+ adi,pin14-function = "tach4";
};
};

--
2.35.1

2022-04-25 04:12:44

by Guenter Roeck

Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Document adt7475 pin-function properties

On Wed, Mar 23, 2022 at 04:40:54PM +1300, Chris Packham wrote:
> The adt7473, adt7475, adt7476 and adt7490 have pins that can be used for
> different functions. Add bindings so that it is possible to describe
> what pin functions are intended by the hardware design.
>
> Signed-off-by: Chris Packham <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Still waiting for DT maintainer approval.

Guenter

> ---
>
> Notes:
> Changes in v3:
> - None
> Changes in v2:
> - Add review from Krzysztof
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> index 7d9c083632b9..22beb37f1bf1 100644
> --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -61,6 +61,26 @@ patternProperties:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> + "adi,pin(5|10)-function":
> + description: |
> + Configures the function for pin 5 on the adi,adt7473 and adi,adt7475. Or
> + pin 10 on the adi,adt7476 and adi,adt7490.
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - pwm2
> + - smbalert#
> +
> + "adi,pin(9|14)-function":
> + description: |
> + Configures the function for pin 9 on the adi,adt7473 and adi,adt7475. Or
> + pin 14 on the adi,adt7476 and adi,adt7490
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - tach4
> + - therm#
> + - smbalert#
> + - gpio
> +
> required:
> - compatible
> - reg
> @@ -79,6 +99,8 @@ examples:
> adi,bypass-attenuator-in0 = <1>;
> adi,bypass-attenuator-in1 = <0>;
> adi,pwm-active-state = <1 0 1>;
> + adi,pin10-function = "smbalert#";
> + adi,pin14-function = "tach4";
> };
> };
>

2022-05-02 20:12:25

by Guenter Roeck

Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Document adt7475 pin-function properties

On Wed, Mar 23, 2022 at 04:40:54PM +1300, Chris Packham wrote:
> The adt7473, adt7475, adt7476 and adt7490 have pins that can be used for
> different functions. Add bindings so that it is possible to describe
> what pin functions are intended by the hardware design.
>
> Signed-off-by: Chris Packham <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>
> Notes:
> Changes in v3:
> - None
> Changes in v2:
> - Add review from Krzysztof
>
> .../devicetree/bindings/hwmon/adt7475.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.yaml b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> index 7d9c083632b9..22beb37f1bf1 100644
> --- a/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.yaml
> @@ -61,6 +61,26 @@ patternProperties:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> + "adi,pin(5|10)-function":
> + description: |
> + Configures the function for pin 5 on the adi,adt7473 and adi,adt7475. Or
> + pin 10 on the adi,adt7476 and adi,adt7490.
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - pwm2
> + - smbalert#
> +
> + "adi,pin(9|14)-function":
> + description: |
> + Configures the function for pin 9 on the adi,adt7473 and adi,adt7475. Or
> + pin 14 on the adi,adt7476 and adi,adt7490
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - tach4
> + - therm#
> + - smbalert#
> + - gpio
> +
> required:
> - compatible
> - reg
> @@ -79,6 +99,8 @@ examples:
> adi,bypass-attenuator-in0 = <1>;
> adi,bypass-attenuator-in1 = <0>;
> adi,pwm-active-state = <1 0 1>;
> + adi,pin10-function = "smbalert#";
> + adi,pin14-function = "tach4";
> };
> };
>