2022-05-02 23:32:10

by Hector Martin

Subject: [PATCH 2/7] mailbox: sun6i: Unexport unused sun6i_msgbox_peek_data

This op was ambiguously specified, and the way it was interpreted for
this implementation is not useful. It has no users, so remove it. The
function is used internally by the driver, so just remove it from the
ops structure.

Signed-off-by: Hector Martin <[email protected]>
---
drivers/mailbox/sun6i-msgbox.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/sun6i-msgbox.c b/drivers/mailbox/sun6i-msgbox.c
index 7f8d931042d3..47aedda80f3f 100644
--- a/drivers/mailbox/sun6i-msgbox.c
+++ b/drivers/mailbox/sun6i-msgbox.c
@@ -189,7 +189,6 @@ static const struct mbox_chan_ops sun6i_msgbox_chan_ops = {
.startup = sun6i_msgbox_startup,
.shutdown = sun6i_msgbox_shutdown,
.last_tx_done = sun6i_msgbox_last_tx_done,
- .peek_data = sun6i_msgbox_peek_data,
};

static int sun6i_msgbox_probe(struct platform_device *pdev)
--
2.35.1

2022-05-03 01:27:13

by Samuel Holland

Subject: Re: [PATCH 2/7] mailbox: sun6i: Unexport unused sun6i_msgbox_peek_data

On 5/2/22 4:02 AM, Hector Martin wrote:
> This op was ambiguously specified, and the way it was interpreted for
> this implementation is not useful. It has no users, so remove it. The
> function is used internally by the driver, so just remove it from the
> ops structure.
>
> Signed-off-by: Hector Martin <[email protected]>

Acked-by: Samuel Holland <[email protected]>