2022-05-02 23:34:26

by Hector Martin

Subject: [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example

We no longer use these since 111659c2a570 (and they never worked
anyway); drop them from the example to avoid confusion.

Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
Signed-off-by: Hector Martin <[email protected]>
---
Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
index 7f01e15fc81c..daf602ac0d0f 100644
--- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
@@ -142,7 +142,6 @@ examples:
device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 152 0>;
- max-link-speed = <2>;

#address-cells = <3>;
#size-cells = <2>;
@@ -153,7 +152,6 @@ examples:
device_type = "pci";
reg = <0x800 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 153 0>;
- max-link-speed = <2>;

#address-cells = <3>;
#size-cells = <2>;
@@ -164,7 +162,6 @@ examples:
device_type = "pci";
reg = <0x1000 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 33 0>;
- max-link-speed = <1>;

#address-cells = <3>;
#size-cells = <2>;
--
2.35.1

2022-05-02 23:36:07

by Alyssa Rosenzweig

Subject: Re: [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example

Reviewed-by: Alyssa Rosenzweig <[email protected]>
On Mon, May 02, 2022 at 06:13:08PM +0900, Hector Martin wrote:
> We no longer use these since 111659c2a570 (and they never worked
> anyway); drop them from the example to avoid confusion.
>
> Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
> Signed-off-by: Hector Martin <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> index 7f01e15fc81c..daf602ac0d0f 100644
> --- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> @@ -142,7 +142,6 @@ examples:
> device_type = "pci";
> reg = <0x0 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 152 0>;
> - max-link-speed = <2>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -153,7 +152,6 @@ examples:
> device_type = "pci";
> reg = <0x800 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 153 0>;
> - max-link-speed = <2>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -164,7 +162,6 @@ examples:
> device_type = "pci";
> reg = <0x1000 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 33 0>;
> - max-link-speed = <1>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> --
> 2.35.1
>

2022-05-09 08:03:09

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example

On Mon, 02 May 2022 18:13:08 +0900, Hector Martin wrote:
> We no longer use these since 111659c2a570 (and they never worked
> anyway); drop them from the example to avoid confusion.
>
> Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
> Signed-off-by: Hector Martin <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>

Applied, thanks!