2022-05-02 18:25:33

by Shubhrajyoti Datta

Subject: [PATCH v2] gpio: xilinx: add missing blank line after declarations

Add a missing blank line. No functional changes.

WARNING: Missing a blank line after declarations
128: FILE: drivers/gpio/gpio-xilinx.c:120:
+ void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+ xgpio_set_value32(a, bit, xgpio_readreg(addr));

WARNING: Missing a blank line after declarations
136: FILE: drivers/gpio/gpio-xilinx.c:126:
+ void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+ xgpio_writereg(addr, xgpio_get_value32(a, bit));

Reviewed-by: Radhey Shyam Pandey <[email protected]>
Signed-off-by: Shubhrajyoti Datta <[email protected]>
---
v2: Update commit message

drivers/gpio/gpio-xilinx.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index b6d3a57e27ed..7f129e7eae78 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
{
void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
xgpio_set_value32(a, bit, xgpio_readreg(addr));
}

static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
{
void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
xgpio_writereg(addr, xgpio_get_value32(a, bit));
}

--
2.17.1

2022-06-21 10:27:23

by Datta, Shubhrajyoti

Subject: RE: [PATCH v2] gpio: xilinx: add missing blank line after declarations

[AMD Official Use Only - General]



> -----Original Message-----
> From: Shubhrajyoti Datta <[email protected]>
> Sent: Monday, May 2, 2022 4:31 PM
> To: [email protected]
> Cc: Michal Simek <[email protected]>; Srinivas Neeli <[email protected]>;
> [email protected]; git <[email protected]>; Shubhrajyoti Datta
> <[email protected]>
> Subject: [PATCH v2] gpio: xilinx: add missing blank line after declarations
>
> Add a missing blank line. No functional changes.
>
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_set_value32(a, bit, xgpio_readreg(addr));
>
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_writereg(addr, xgpio_get_value32(a, bit));
>
> Reviewed-by: Radhey Shyam Pandey <[email protected]>
> Signed-off-by: Shubhrajyoti Datta <[email protected]>
> ---
If there are no further comments can it be merged.

2022-07-07 13:22:34

by Michal Simek

Subject: Re: [PATCH v2] gpio: xilinx: add missing blank line after declarations

On 5/2/22 13:00, Shubhrajyoti Datta wrote:
> Add a missing blank line. No functional changes.
>
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_set_value32(a, bit, xgpio_readreg(addr));
>
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> + void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> + xgpio_writereg(addr, xgpio_get_value32(a, bit));
>
> Reviewed-by: Radhey Shyam Pandey <[email protected]>
> Signed-off-by: Shubhrajyoti Datta <[email protected]>
> ---
> v2: Update commit message
>
> drivers/gpio/gpio-xilinx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
> static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
> {
> void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
> xgpio_set_value32(a, bit, xgpio_readreg(addr));
> }
>
> static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
> {
> void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
> xgpio_writereg(addr, xgpio_get_value32(a, bit));
> }
>


Fixes: 02b3f84d9080 ("gpio: xilinx: Switch to use bitmap APIs")

Reviewed-by: Michal Simek <[email protected]>

Bartosz: Can you please apply it?

Thanks,
Michal