2022-05-03 01:18:57

by kernel test robot

[permalink] [raw]
Subject: [asahilinux:bits/090-spi-hid 11/11] drivers/hid/spi-hid/spi-hid-apple-core.c:259:22: warning: no previous prototype for function 'spihid_get_data'

tree: https://github.com/AsahiLinux/linux bits/090-spi-hid
head: 11b586fd5cff82ad72e9a281c0deb27959d16857
commit: 11b586fd5cff82ad72e9a281c0deb27959d16857 [11/11] WIP: HID: transport: spi: add Apple SPI transport
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20220503/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 09325d36061e42b495d1f4c7e933e260eac260ed)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/AsahiLinux/linux/commit/11b586fd5cff82ad72e9a281c0deb27959d16857
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux bits/090-spi-hid
git checkout 11b586fd5cff82ad72e9a281c0deb27959d16857
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/dma/ drivers/hid/spi-hid/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/hid/spi-hid/spi-hid-apple-core.c:259:22: warning: no previous prototype for function 'spihid_get_data' [-Wmissing-prototypes]
struct spihid_apple *spihid_get_data(struct spihid_interface *idev)
^
drivers/hid/spi-hid/spi-hid-apple-core.c:259:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct spihid_apple *spihid_get_data(struct spihid_interface *idev)
^
static
drivers/hid/spi-hid/spi-hid-apple-core.c:56:17: warning: variable 'spi_hid_apple_status_ok' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const u8 spi_hid_apple_status_ok[4] = { 0xac, 0x27, 0x68, 0xd5 };
^
2 warnings generated.
--
>> drivers/hid/spi-hid/spi-hid-apple-of.c:24:5: warning: no previous prototype for function 'spihid_apple_of_power_on' [-Wmissing-prototypes]
int spihid_apple_of_power_on(struct spihid_apple_ops *ops)
^
drivers/hid/spi-hid/spi-hid-apple-of.c:24:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int spihid_apple_of_power_on(struct spihid_apple_ops *ops)
^
static
>> drivers/hid/spi-hid/spi-hid-apple-of.c:40:5: warning: no previous prototype for function 'spihid_apple_of_power_off' [-Wmissing-prototypes]
int spihid_apple_of_power_off(struct spihid_apple_ops *ops)
^
drivers/hid/spi-hid/spi-hid-apple-of.c:40:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int spihid_apple_of_power_off(struct spihid_apple_ops *ops)
^
static
>> drivers/hid/spi-hid/spi-hid-apple-of.c:50:5: warning: no previous prototype for function 'spihid_apple_of_enable_irq' [-Wmissing-prototypes]
int spihid_apple_of_enable_irq(struct spihid_apple_ops *ops)
^
drivers/hid/spi-hid/spi-hid-apple-of.c:50:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int spihid_apple_of_enable_irq(struct spihid_apple_ops *ops)
^
static
>> drivers/hid/spi-hid/spi-hid-apple-of.c:59:5: warning: no previous prototype for function 'spihid_apple_of_disable_irq' [-Wmissing-prototypes]
int spihid_apple_of_disable_irq(struct spihid_apple_ops *ops)
^
drivers/hid/spi-hid/spi-hid-apple-of.c:59:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int spihid_apple_of_disable_irq(struct spihid_apple_ops *ops)
^
static
4 warnings generated.


vim +/spihid_get_data +259 drivers/hid/spi-hid/spi-hid-apple-core.c

258
> 259 struct spihid_apple *spihid_get_data(struct spihid_interface *idev)
260 {
261 switch (idev->id) {
262 case SPIHID_DEVICE_ID_KBD:
263 return container_of(idev, struct spihid_apple, kbd);
264 case SPIHID_DEVICE_ID_TP:
265 return container_of(idev, struct spihid_apple, tp);
266 default:
267 return NULL;
268 }
269 }
270

--
0-DAY CI Kernel Test Service
https://01.org/lkp