2022-05-03 17:59:12

by Eugen Hristev

Subject: [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node

interrupt-parent is not to be used as a boolean property.
It is already present in the DT in the proper way it's supposed to be used:
interrupt-parent = <&gic>;

This is also reported by dtbs_check:
arch/arm/boot/dts/at91-sama7g5ek.dtb: interrupt-controller@e8c11000: interrupt-parent: True is not of type 'array'
From schema: /.local/lib/python3.8/site-packages/dtschema/schemas/interrupts.yaml

Fixes: 7540629e2fc7 ("ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek")
Signed-off-by: Eugen Hristev <[email protected]>
---
arch/arm/boot/dts/sama7g5.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
index cdaa9c825f69..f4f174314e4e 100644
--- a/arch/arm/boot/dts/sama7g5.dtsi
+++ b/arch/arm/boot/dts/sama7g5.dtsi
@@ -949,7 +949,6 @@ gic: interrupt-controller@e8c11000 {
#interrupt-cells = <3>;
#address-cells = <0>;
interrupt-controller;
- interrupt-parent;
reg = <0xe8c11000 0x1000>,
<0xe8c12000 0x2000>;
};
--
2.25.1

2022-05-09 10:13:01

by Claudiu Beznea

Subject: Re: [PATCH] ARM: dts: at91: sama7g5: remove interrupt-parent from gic node

On 03.05.2022 16:31, Eugen Hristev wrote:
> interrupt-parent is not to be used as a boolean property.
> It is already present in the DT in the proper way it's supposed to be used:
> interrupt-parent = <&gic>;
>
> This is also reported by dtbs_check:
> arch/arm/boot/dts/at91-sama7g5ek.dtb: interrupt-controller@e8c11000: interrupt-parent: True is not of type 'array'
> From schema: /.local/lib/python3.8/site-packages/dtschema/schemas/interrupts.yaml
>
> Fixes: 7540629e2fc7 ("ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek")
> Signed-off-by: Eugen Hristev <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>

> ---
> arch/arm/boot/dts/sama7g5.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index cdaa9c825f69..f4f174314e4e 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -949,7 +949,6 @@ gic: interrupt-controller@e8c11000 {
> #interrupt-cells = <3>;
> #address-cells = <0>;
> interrupt-controller;
> - interrupt-parent;
> reg = <0xe8c11000 0x1000>,
> <0xe8c12000 0x2000>;
> };