2022-04-12 23:39:19

by Saurabh Singh Sengar

Subject: [PATCH v4] drm/hyperv: Add error message for fb size greater than allocated

Add error message when the size of requested framebuffer is more than
the allocated size by vmbus mmio region for framebuffer

Signed-off-by: Saurabh Sengar <[email protected]>
---
v3 -> v4 :
* Shorter error message
* Alignment match for open parenthesis
* Added -> Add (typo fix in commit message)

drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index e82b815..27f4fcb 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -123,8 +123,11 @@ static int hyperv_pipe_check(struct drm_simple_display_pipe *pipe,
if (fb->format->format != DRM_FORMAT_XRGB8888)
return -EINVAL;

- if (fb->pitches[0] * fb->height > hv->fb_size)
+ if (fb->pitches[0] * fb->height > hv->fb_size) {
+ drm_err(&hv->dev, "fb size requested by %s for %dX%d (pitch %d) greater than %ld\n",
+ current->comm, fb->width, fb->height, fb->pitches[0], hv->fb_size);
return -EINVAL;
+ }

return 0;
}
--
1.8.3.1

2022-05-03 15:19:09

by Wei Liu

Subject: Re: [PATCH v4] drm/hyperv: Add error message for fb size greater than allocated

On Tue, May 03, 2022 at 07:50:16AM -0700, Saurabh Singh Sengar wrote:
> On Tue, Apr 12, 2022 at 05:06:07AM +0000, Dexuan Cui wrote:
> > > From: Saurabh Sengar <[email protected]>
> > > Sent: Monday, April 11, 2022 9:29 PM
> > > ...
> > > Add error message when the size of requested framebuffer is more than
> > > the allocated size by vmbus mmio region for framebuffer
> >
> > The line lacks a period, but I guess the maintainer may help fix it for you :-)
> >
> > > Signed-off-by: Saurabh Sengar <[email protected]>
> >
> > Reviewed-by: Dexuan Cui <[email protected]>
>
> Can this be queued for next ? please let me know in case any clarification required.

Applied to hyperv-next. Thanks.