2022-05-04 23:08:04

by Stanislav Jakubek

Subject: [PATCH RESEND,v2] dt-bindings: timer: Convert rda,8810pl-timer to YAML

Convert RDA Micro Timer bindings to DT schema format.

Signed-off-by: Stanislav Jakubek <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
---
Changes in v2:
- Collect Krzysztof's and Manivannan's R-b's

It's been a month since the original v2, 2 months since v1,
so I figured it's about time for a resend.

.../bindings/timer/rda,8810pl-timer.txt | 20 --------
.../bindings/timer/rda,8810pl-timer.yaml | 47 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 48 insertions(+), 21 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml

diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt
deleted file mode 100644
index 4db542c9a0fd..000000000000
--- a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-RDA Micro RDA8810PL Timer
-
-Required properties:
-- compatible : "rda,8810pl-timer"
-- reg : Offset and length of the register set for the device.
-- interrupts : Should contain two interrupts.
-- interrupt-names : Should be "hwtimer", "ostimer".
-
-Example:
-
- apb@20900000 {
- compatible = "simple-bus";
- ...
- timer@10000 {
- compatible = "rda,8810pl-timer";
- reg = <0x10000 0x1000>;
- interrupts = <16 IRQ_TYPE_LEVEL_HIGH>,
- <17 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "hwtimer", "ostimer";
- };
diff --git a/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml
new file mode 100644
index 000000000000..f9043a4488d6
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/rda,8810pl-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: RDA Micro RDA8810PL Timer
+
+maintainers:
+ - Manivannan Sadhasivam <[email protected]>
+
+properties:
+ compatible:
+ const: rda,8810pl-timer
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 2
+ maxItems: 2
+
+ interrupt-names:
+ items:
+ - const: hwtimer
+ - const: ostimer
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ timer@20910000 {
+ compatible = "rda,8810pl-timer";
+ reg = <0x20910000 0x1000>;
+ interrupts = <16 IRQ_TYPE_LEVEL_HIGH>,
+ <17 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hwtimer", "ostimer";
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 6d5c2c035f82..cbf91f0ecbfb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2563,7 +2563,7 @@ F: Documentation/devicetree/bindings/arm/rda.yaml
F: Documentation/devicetree/bindings/gpio/gpio-rda.yaml
F: Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt
F: Documentation/devicetree/bindings/serial/rda,8810pl-uart.yaml
-F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt
+F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml
F: arch/arm/boot/dts/rda8810pl-*
F: drivers/clocksource/timer-rda.c
F: drivers/gpio/gpio-rda.c
--
2.25.1

2022-05-09 05:59:41

by Rob Herring (Arm)

Subject: Re: [PATCH RESEND,v2] dt-bindings: timer: Convert rda,8810pl-timer to YAML

On Wed, 04 May 2022 19:55:02 +0200, Stanislav Jakubek wrote:
> Convert RDA Micro Timer bindings to DT schema format.
>
> Signed-off-by: Stanislav Jakubek <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Manivannan Sadhasivam <[email protected]>
> ---
> Changes in v2:
> - Collect Krzysztof's and Manivannan's R-b's
>
> It's been a month since the original v2, 2 months since v1,
> so I figured it's about time for a resend.
>
> .../bindings/timer/rda,8810pl-timer.txt | 20 --------
> .../bindings/timer/rda,8810pl-timer.yaml | 47 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 48 insertions(+), 21 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.txt
> create mode 100644 Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml
>

Applied, thanks!