2022-05-06 07:01:41

by Rafał Miłecki

Subject: [PATCH RESEND 2/5] dt-bindings: net: allow Ethernet devices as LED triggers

From: Rafał Miłecki <[email protected]>

This allows specifying Ethernet interfaces and switch ports as triggers
for LEDs activity.

Signed-off-by: Rafał Miłecki <[email protected]>
---
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 4f15463611f8..ebeb4446d253 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -232,6 +232,9 @@ properties:
required:
- speed

+allOf:
+ - $ref: /schemas/leds/trigger-source.yaml
+
additionalProperties: true

...
--
2.34.1

2022-05-18 04:53:41

by Rob Herring (Arm)

Subject: Re: [PATCH RESEND 2/5] dt-bindings: net: allow Ethernet devices as LED triggers

On Thu, May 05, 2022 at 03:55:09PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> This allows specifying Ethernet interfaces and switch ports as triggers
> for LEDs activity.
>
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 4f15463611f8..ebeb4446d253 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -232,6 +232,9 @@ properties:
> required:
> - speed
>
> +allOf:
> + - $ref: /schemas/leds/trigger-source.yaml

There's no need to add this here. A device binding still has to list
'#trigger-source-cells' and set it's value to 0 or 1 cell.

Rob