2022-05-09 02:19:23

by Yihao Han

Subject: [PATCH] i2c: s3c2410: fix returnvar.cocci warning

Fix the following coccicheck warning:

drivers/i2c/busses/i2c-s3c2410.c:388:5-8: Unneeded variable: "ret".
Return "0" on line 551

Signed-off-by: Yihao Han <[email protected]>
---
drivers/i2c/busses/i2c-s3c2410.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index b49a1b170bb2..6df85b23156c 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
{
unsigned long tmp;
unsigned char byte;
- int ret = 0;

switch (i2c->state) {

@@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
tmp &= ~S3C2410_IICCON_IRQPEND;
writel(tmp, i2c->regs + S3C2410_IICCON);
out:
- return ret;
+ return 0;
}

/*
--
2.17.1

2022-05-09 09:30:23

by Krzysztof Kozlowski

Subject: Re: [PATCH] i2c: s3c2410: fix returnvar.cocci warning

On 06/05/2022 09:31, Yihao Han wrote:
> Fix the following coccicheck warning:
>
> drivers/i2c/busses/i2c-s3c2410.c:388:5-8: Unneeded variable: "ret".
> Return "0" on line 551
>
> Signed-off-by: Yihao Han <[email protected]>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

This was already reported:
https://lore.kernel.org/all/[email protected]/

Please apply instead my previous suggestion.


Best regards,
Krzysztof