2022-05-09 03:09:53

by zhenwei pi

Subject: [PATCH 1/3] nvme: introduce bit 5 of smart critical warning

According to NVM Express v1.4, Section 5.14.1.2 ("SMART / Health
Information"), introduce bit 5 for "Persistent Memory Region has become
read-only or unreliable".

Signed-off-by: zhenwei pi <[email protected]>
---
include/linux/nvme.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index f626a445d1a8..882ad7523127 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -662,6 +662,7 @@ enum {
NVME_SMART_CRIT_RELIABILITY = 1 << 2,
NVME_SMART_CRIT_MEDIA = 1 << 3,
NVME_SMART_CRIT_VOLATILE_MEMORY = 1 << 4,
+ NVME_SMART_CRIT_PMR_UNRELIABLE = 1 << 5,
};

enum {
--
2.20.1

2022-05-10 13:24:36

by Christoph Hellwig

Subject: Re: [PATCH 1/3] nvme: introduce bit 5 of smart critical warning

On Sat, May 07, 2022 at 02:50:24PM +0800, zhenwei pi wrote:
> According to NVM Express v1.4, Section 5.14.1.2 ("SMART / Health
> Information"), introduce bit 5 for "Persistent Memory Region has become
> read-only or unreliable".

Given that Linux does not support the PMR, do we really need this?

2022-05-10 13:45:55

by zhenwei pi

Subject: Re: Re: [PATCH 1/3] nvme: introduce bit 5 of smart critical warning

On 5/10/22 13:49, Christoph Hellwig wrote:
> On Sat, May 07, 2022 at 02:50:24PM +0800, zhenwei pi wrote:
>> According to NVM Express v1.4, Section 5.14.1.2 ("SMART / Health
>> Information"), introduce bit 5 for "Persistent Memory Region has become
>> read-only or unreliable".
>
> Given that Linux does not support the PMR, do we really need this?

OK, let's drop this change.

Klaus Jensen corrected me about OAES[7:0]. Sorry, I misunderstand this.

--
zhenwei pi