2022-05-09 04:03:29

by Jason Wang

[permalink] [raw]
Subject: [PATCH] w1: no need to initialise statics to 0

Static variables do not need to be initialised to 0, because compiler
will initialise all uninitialised statics to 0. Thus, remove the
unneeded initializations.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/w1/w1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index f2ae2e563dc5..bb28e36993d6 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -32,7 +32,7 @@ static int w1_timeout = 10;
module_param_named(timeout, w1_timeout, int, 0);
MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");

-static int w1_timeout_us = 0;
+static int w1_timeout_us;
module_param_named(timeout_us, w1_timeout_us, int, 0);
MODULE_PARM_DESC(timeout_us,
"time in microseconds between automatic slave searches");
--
2.35.1




2023-05-08 09:31:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] w1: no need to initialise statics to 0


On Sun, 08 May 2022 10:34:00 +0800, Jason Wang wrote:
> Static variables do not need to be initialised to 0, because compiler
> will initialise all uninitialised statics to 0. Thus, remove the
> unneeded initializations.
>
>

Applied, thanks!

[1/1] w1: no need to initialise statics to 0
https://git.kernel.org/krzk/linux-w1/c/ecaed1a26f7215f48420a9c02e229b84b5fbb882

Best regards,
--
Krzysztof Kozlowski <[email protected]>