Fix the warning - "Enum value 'NR_DAMON_OPS' not described in
enum 'damon_ops_id'" generated by the command "make pdfdocs"
Signed-off-by: Gautam Menghani <[email protected]>
---
Changes in v3:
- Add the subsystem in subject.
- Modify the description for NR_DAMON_OPS field.
Changes in v2:
- Fix checkpatch warning of 75 characters per line
- Fix email mismatch in from and signed by field
include/linux/damon.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index f23cbfa4248d..b972a7a3b6f0 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -262,6 +262,7 @@ struct damos {
*
* @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces
* @DAMON_OPS_PADDR: Monitoring operations for the physical address space
+ * @NR_DAMON_OPS: Number of monitoring operations implementations
*/
enum damon_ops_id {
DAMON_OPS_VADDR,
--
2.25.1
Hi Gautam,
On Sun, 8 May 2022 13:03:16 +0530 Gautam Menghani <[email protected]> wrote:
> Fix the warning - "Enum value 'NR_DAMON_OPS' not described in
> enum 'damon_ops_id'" generated by the command "make pdfdocs"
>
> Signed-off-by: Gautam Menghani <[email protected]>
> ---
> Changes in v3:
> - Add the subsystem in subject.
> - Modify the description for NR_DAMON_OPS field.
Thank you for making the changes.
Reviewed-by: SeongJae Park <[email protected]>
Thanks,
SJ
>
> Changes in v2:
> - Fix checkpatch warning of 75 characters per line
> - Fix email mismatch in from and signed by field
>
> include/linux/damon.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index f23cbfa4248d..b972a7a3b6f0 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -262,6 +262,7 @@ struct damos {
> *
> * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces
> * @DAMON_OPS_PADDR: Monitoring operations for the physical address space
> + * @NR_DAMON_OPS: Number of monitoring operations implementations
> */
> enum damon_ops_id {
> DAMON_OPS_VADDR,
> --
> 2.25.1
>
Hi Gautam,
I just found this patch is not cleanly applicable on top of the mm-unstable
branch[1]. Could you please rebase?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-unstable
Thanks,
SJ
On Sun, 8 May 2022 09:19:43 +0000 SeongJae Park <[email protected]> wrote:
> Hi Gautam,
>
>
> On Sun, 8 May 2022 13:03:16 +0530 Gautam Menghani <[email protected]> wrote:
>
> > Fix the warning - "Enum value 'NR_DAMON_OPS' not described in
> > enum 'damon_ops_id'" generated by the command "make pdfdocs"
> >
> > Signed-off-by: Gautam Menghani <[email protected]>
> > ---
> > Changes in v3:
> > - Add the subsystem in subject.
> > - Modify the description for NR_DAMON_OPS field.
>
> Thank you for making the changes.
>
> Reviewed-by: SeongJae Park <[email protected]>
>
>
> Thanks,
> SJ
>
> >
> > Changes in v2:
> > - Fix checkpatch warning of 75 characters per line
> > - Fix email mismatch in from and signed by field
> >
> > include/linux/damon.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index f23cbfa4248d..b972a7a3b6f0 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> > @@ -262,6 +262,7 @@ struct damos {
> > *
> > * @DAMON_OPS_VADDR: Monitoring operations for virtual address spaces
> > * @DAMON_OPS_PADDR: Monitoring operations for the physical address space
> > + * @NR_DAMON_OPS: Number of monitoring operations implementations
> > */
> > enum damon_ops_id {
> > DAMON_OPS_VADDR,
> > --
> > 2.25.1
> >
On Mon, 9 May 2022 08:11:54 +0000 SeongJae Park <[email protected]> wrote:
> I just found this patch is not cleanly applicable on top of the mm-unstable
> branch[1]. Could you please rebase?
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-unstable
I got it. It was just the DAMON_OPS_VADDR->DAMON_OPS_FVADDR rename.