2022-05-09 10:44:42

by Kavyasree Kotagiri

[permalink] [raw]
Subject: [PATCH v2 0/4] Add support for lan966 flexcom multiplexer

This patch series implements driver for lan966 flexcom multiplexer.
Converts atmel-flexcom.txt bindings to yaml format and add new
compatible string for lan966 flexcom.

This patch also adds dt bindings for lan966 flexcom multiplexer.

v1 -> v2:
- addressed comments for atmel,flexcom.yaml.
- added child node and its parameters properly in flexcom bindings.
- added ref to mux-consumer.yaml.
- added ref to mux-controller.yaml in lan966-flx-mux.yaml
- added MODULE() stuff in lan966 mux driver.

Kavyasree Kotagiri (4):
dt-bindings: mfd: atmel,flexcom: Convert to json-schema
dt-bindings: mfd: atmel,flexcom: Add lan966 compatible string and mux
properties
dt-bindings: mux: Add lan966 flexcom mux controller
mux: lan966: Add support for flexcom mux controller

.../bindings/mfd/atmel,flexcom.yaml | 142 ++++++++++++++++++
.../devicetree/bindings/mfd/atmel-flexcom.txt | 63 --------
.../mux/microchip,lan966-flx-mux.yaml | 51 +++++++
arch/arm/mach-at91/Kconfig | 2 +
drivers/mfd/atmel-flexcom.c | 55 ++++++-
drivers/mux/Kconfig | 12 ++
drivers/mux/Makefile | 2 +
drivers/mux/lan966-flx.c | 121 +++++++++++++++
8 files changed, 384 insertions(+), 64 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
create mode 100644 Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
create mode 100644 drivers/mux/lan966-flx.c

--
2.17.1



2022-05-09 10:45:07

by Kavyasree Kotagiri

[permalink] [raw]
Subject: [PATCH v2 3/4] dt-bindings: mux: Add lan966 flexcom mux controller

This adds DT bindings documentation for lan966 flexcom
mux controller.

Signed-off-by: Kavyasree Kotagiri <[email protected]>
---
.../mux/microchip,lan966-flx-mux.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml

diff --git a/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
new file mode 100644
index 000000000000..63147a2e8f3a
--- /dev/null
+++ b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mux/microchip,lan966-flx-mux.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip Lan966 Flexcom multiplexer bindings
+
+maintainers:
+ - Kavyasree Kotagiri <[email protected]>
+
+description: |+
+ The Microchip Lan966 have 5 Flexcoms. Each flexcom has 2 chip-selects
+ when operating in USART and SPI modes.
+ Each chip select of each flexcom can be mapped to 21 flexcom shared pins.
+ Define register offset and pin number to map a flexcom chip-select
+ to flexcom shared pin.
+
+allOf:
+ - $ref: /schemas/mux/mux-controller.yaml#
+
+properties:
+ compatible:
+ const: microchip,lan966-flx-mux
+
+ reg:
+ maxItems: 1
+
+ '#mux-control-cells':
+ const: 1
+
+ mux-offset-pin:
+ description: an array of register offset and flexcom shared pin(0-20).
+
+required:
+ - compatible
+ - reg
+ - '#mux-control-cells'
+ - mux-offset-pin
+
+additionalProperties: false
+
+examples:
+ - |
+ mux: mux-controller@e2004168 {
+ compatible = "microchip,lan966-flx-mux";
+ reg = <0xe2004168 0x8>;
+ #mux-control-cells = <1>;
+ mux-offset-pin = <0x18 9>; /* 0: flx3 cs0 offset, pin-9 */
+ };
+...
--
2.17.1


2022-05-10 15:59:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] dt-bindings: mux: Add lan966 flexcom mux controller

On 09/05/2022 10:49, Kavyasree Kotagiri wrote:
> This adds DT bindings documentation for lan966 flexcom
> mux controller.
>
> Signed-off-by: Kavyasree Kotagiri <[email protected]>
> ---
> .../mux/microchip,lan966-flx-mux.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
>
> diff --git a/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
> new file mode 100644
> index 000000000000..63147a2e8f3a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mux/microchip,lan966-flx-mux.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mux/microchip,lan966-flx-mux.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip Lan966 Flexcom multiplexer bindings

s/bindings//

> +
> +maintainers:
> + - Kavyasree Kotagiri <[email protected]>
> +
> +description: |+

No need for |+

> + The Microchip Lan966 have 5 Flexcoms. Each flexcom has 2 chip-selects
> + when operating in USART and SPI modes.
> + Each chip select of each flexcom can be mapped to 21 flexcom shared pins.
> + Define register offset and pin number to map a flexcom chip-select
> + to flexcom shared pin.
> +
> +allOf:
> + - $ref: /schemas/mux/mux-controller.yaml#
> +
> +properties:
> + compatible:
> + const: microchip,lan966-flx-mux
> +
> + reg:
> + maxItems: 1
> +
> + '#mux-control-cells':
> + const: 1
> +
> + mux-offset-pin:
> + description: an array of register offset and flexcom shared pin(0-20).

This does not look like generic property, so you need vendor prefix and
type/ref.

> +
> +required:
> + - compatible
> + - reg
> + - '#mux-control-cells'
> + - mux-offset-pin
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mux: mux-controller@e2004168 {
> + compatible = "microchip,lan966-flx-mux";
> + reg = <0xe2004168 0x8>;
> + #mux-control-cells = <1>;
> + mux-offset-pin = <0x18 9>; /* 0: flx3 cs0 offset, pin-9 */
> + };
> +...


Best regards,
Krzysztof