2022-05-10 20:49:15

by Shunsuke Mie

Subject: [RFC PATCH] virtio: fix virtio transitional ids

This commit fixes the transitional PCI device ID.

Fixes: d61914ea6ada ("virtio: update virtio id table, add transitional ids")
Signed-off-by: Shunsuke Mie <[email protected]>
---
include/uapi/linux/virtio_ids.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
index 80d76b75bccd..7aa2eb766205 100644
--- a/include/uapi/linux/virtio_ids.h
+++ b/include/uapi/linux/virtio_ids.h
@@ -73,12 +73,12 @@
* Virtio Transitional IDs
*/

-#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */
-#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */
-#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */
-#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */
-#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */
-#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */
-#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */
+#define VIRTIO_TRANS_ID_NET 0x1000 /* transitional virtio net */
+#define VIRTIO_TRANS_ID_BLOCK 0x1001 /* transitional virtio block */
+#define VIRTIO_TRANS_ID_BALLOON 0x1002 /* transitional virtio balloon */
+#define VIRTIO_TRANS_ID_CONSOLE 0x1003 /* transitional virtio console */
+#define VIRTIO_TRANS_ID_SCSI 0x1004 /* transitional virtio SCSI */
+#define VIRTIO_TRANS_ID_RNG 0x1005 /* transitional virtio rng */
+#define VIRTIO_TRANS_ID_9P 0x1009 /* transitional virtio 9p console */

#endif /* _LINUX_VIRTIO_IDS_H */
--
2.17.1

2022-05-10 21:01:08

by Michael S. Tsirkin

Subject: Re: [RFC PATCH] virtio: fix virtio transitional ids

On Tue, May 10, 2022 at 07:27:23PM +0900, Shunsuke Mie wrote:
> This commit fixes the transitional PCI device ID.
>
> Fixes: d61914ea6ada ("virtio: update virtio id table, add transitional ids")
> Signed-off-by: Shunsuke Mie <[email protected]>

Absolutely! I don't understand how I could have missed this.

Applied, thanks!

> ---
> include/uapi/linux/virtio_ids.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
> index 80d76b75bccd..7aa2eb766205 100644
> --- a/include/uapi/linux/virtio_ids.h
> +++ b/include/uapi/linux/virtio_ids.h
> @@ -73,12 +73,12 @@
> * Virtio Transitional IDs
> */
>
> -#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */
> -#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */
> -#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */
> -#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */
> -#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */
> -#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */
> -#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */
> +#define VIRTIO_TRANS_ID_NET 0x1000 /* transitional virtio net */
> +#define VIRTIO_TRANS_ID_BLOCK 0x1001 /* transitional virtio block */
> +#define VIRTIO_TRANS_ID_BALLOON 0x1002 /* transitional virtio balloon */
> +#define VIRTIO_TRANS_ID_CONSOLE 0x1003 /* transitional virtio console */
> +#define VIRTIO_TRANS_ID_SCSI 0x1004 /* transitional virtio SCSI */
> +#define VIRTIO_TRANS_ID_RNG 0x1005 /* transitional virtio rng */
> +#define VIRTIO_TRANS_ID_9P 0x1009 /* transitional virtio 9p console */
>
> #endif /* _LINUX_VIRTIO_IDS_H */
> --
> 2.17.1