2022-05-10 11:18:55

by Akhil P Oommen

[permalink] [raw]
Subject: [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

Add a new sku to the fuse map of 7c3 gpu.

Signed-off-by: Akhil P Oommen <[email protected]>
---

(no changes since v1)

drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index 841e47a..61bb21d 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1771,6 +1771,8 @@ static u32 adreno_7c3_get_speed_bin(u32 fuse)
return 0;
else if (fuse == 190)
return 1;
+ else if (fuse == 96)
+ return 2;

return UINT_MAX;
}
--
2.7.4



2022-06-29 05:06:49

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote:

> Add a new sku to the fuse map of 7c3 gpu.
>
> Signed-off-by: Akhil P Oommen <[email protected]>

Is this series still needed/wanted? I've been waiting for patch 1 to be
merged in the driver so that I can pick up the dts change.

Regards,
Bjorn

> ---
>
> (no changes since v1)
>
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 841e47a..61bb21d 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1771,6 +1771,8 @@ static u32 adreno_7c3_get_speed_bin(u32 fuse)
> return 0;
> else if (fuse == 190)
> return 1;
> + else if (fuse == 96)
> + return 2;
>
> return UINT_MAX;
> }
> --
> 2.7.4
>

2022-06-29 05:48:54

by Akhil P Oommen

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

On 6/29/2022 9:59 AM, Bjorn Andersson wrote:
> On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote:
>
>> Add a new sku to the fuse map of 7c3 gpu.
>>
>> Signed-off-by: Akhil P Oommen <[email protected]>
> Is this series still needed/wanted? I've been waiting for patch 1 to be
> merged in the driver so that I can pick up the dts change.
>
> Regards,
> Bjorn
Internally, this sku is on hold. So we can drop this series for now. I
will resend it if required in future.

-Akhil.

>
>> ---
>>
>> (no changes since v1)
>>
>> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> index 841e47a..61bb21d 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
>> @@ -1771,6 +1771,8 @@ static u32 adreno_7c3_get_speed_bin(u32 fuse)
>> return 0;
>> else if (fuse == 190)
>> return 1;
>> + else if (fuse == 96)
>> + return 2;
>>
>> return UINT_MAX;
>> }
>> --
>> 2.7.4
>>

2022-06-29 16:26:53

by Rob Clark

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

On Tue, Jun 28, 2022 at 10:32 PM Akhil P Oommen
<[email protected]> wrote:
>
> On 6/29/2022 9:59 AM, Bjorn Andersson wrote:
> > On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote:
> >
> >> Add a new sku to the fuse map of 7c3 gpu.
> >>
> >> Signed-off-by: Akhil P Oommen <[email protected]>
> > Is this series still needed/wanted? I've been waiting for patch 1 to be
> > merged in the driver so that I can pick up the dts change.

It just missed the previous merge window by a couple of days.. I was
planning to pick it up for the upcoming merge window

but I don't think the dt bit should depend on the driver bit in this case

> >
> > Regards,
> > Bjorn
> Internally, this sku is on hold. So we can drop this series for now. I
> will resend it if required in future.

ok, I'll hold off for now

BR,
-R

> -Akhil.
>
> >
> >> ---
> >>
> >> (no changes since v1)
> >>
> >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> >> index 841e47a..61bb21d 100644
> >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> >> @@ -1771,6 +1771,8 @@ static u32 adreno_7c3_get_speed_bin(u32 fuse)
> >> return 0;
> >> else if (fuse == 190)
> >> return 1;
> >> + else if (fuse == 96)
> >> + return 2;
> >>
> >> return UINT_MAX;
> >> }
> >> --
> >> 2.7.4
> >>
>