2022-05-10 19:35:47

by Yury Norov

Subject: [PATCH 22/22] clockevents: use cpumask_weight_eq() in tick_cleanup_dead_cpu()

Replace cpumask_weight() with cpumask_weight_eq(..., 1) because the it may
return earlier.

CC: Thomas Gleixner <[email protected]>
CC: [email protected]
Signed-off-by: Yury Norov <[email protected]>
---
kernel/time/clockevents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 5d85014d59b5..fa651263650f 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -648,7 +648,7 @@ void tick_cleanup_dead_cpu(int cpu)
*/
list_for_each_entry_safe(dev, tmp, &clockevent_devices, list) {
if (cpumask_test_cpu(cpu, dev->cpumask) &&
- cpumask_weight(dev->cpumask) == 1 &&
+ cpumask_weight_eq(dev->cpumask, 1) &&
!tick_is_broadcast_device(dev)) {
BUG_ON(!clockevent_state_detached(dev));
list_del(&dev->list);
--
2.32.0

2022-05-11 10:18:54

by Thomas Gleixner

Subject: Re: [PATCH 22/22] clockevents: use cpumask_weight_eq() in tick_cleanup_dead_cpu()

On Tue, May 10 2022 at 08:47, Yury Norov wrote:
> Replace cpumask_weight() with cpumask_weight_eq(..., 1) because the it may
> return earlier.

'because the it'?