Having assets in the top-level `Documentation` directory can make
it harder to find the documents one needs, especially if we want
to add more of them later on.
Instead, create a new `images` folder inside it that is used
to hold assets such as logos.
Link: https://lore.kernel.org/lkml/[email protected]/
Suggested-by: Jonathan Corbet <[email protected]>
Signed-off-by: Miguel Ojeda <[email protected]>
---
Documentation/{ => images}/COPYING-logo | 0
Documentation/{ => images}/logo.gif | Bin
2 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/{ => images}/COPYING-logo (100%)
rename Documentation/{ => images}/logo.gif (100%)
diff --git a/Documentation/COPYING-logo b/Documentation/images/COPYING-logo
similarity index 100%
rename from Documentation/COPYING-logo
rename to Documentation/images/COPYING-logo
diff --git a/Documentation/logo.gif b/Documentation/images/logo.gif
similarity index 100%
rename from Documentation/logo.gif
rename to Documentation/images/logo.gif
base-commit: c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a
--
2.36.1
Miguel Ojeda <[email protected]> writes:
> Having assets in the top-level `Documentation` directory can make
> it harder to find the documents one needs, especially if we want
> to add more of them later on.
>
> Instead, create a new `images` folder inside it that is used
> to hold assets such as logos.
>
> Link: https://lore.kernel.org/lkml/[email protected]/
> Suggested-by: Jonathan Corbet <[email protected]>
> Signed-off-by: Miguel Ojeda <[email protected]>
> ---
> Documentation/{ => images}/COPYING-logo | 0
> Documentation/{ => images}/logo.gif | Bin
> 2 files changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/{ => images}/COPYING-logo (100%)
> rename Documentation/{ => images}/logo.gif (100%)
>
> diff --git a/Documentation/COPYING-logo b/Documentation/images/COPYING-logo
> similarity index 100%
> rename from Documentation/COPYING-logo
> rename to Documentation/images/COPYING-logo
> diff --git a/Documentation/logo.gif b/Documentation/images/logo.gif
> similarity index 100%
> rename from Documentation/logo.gif
> rename to Documentation/images/logo.gif
This will break scripts/spdxcheck-test.sh - which somebody might
actually try to run one of these years. So this patch really needs to
update that script to follow the move.
As far as I can tell, that's the only reference to logo.gif in the
entire tree. It makes me wonder if we need it at all. Digging through
the history suggests it was added in 2.1.15, but never really used for
anything. It's only role would appear to be to serve as testing
material for the SPDX checker..:)
Thanks,
jon
On Thu, May 12, 2022 at 5:37 PM Jonathan Corbet <[email protected]> wrote:
>
> This will break scripts/spdxcheck-test.sh - which somebody might
> actually try to run one of these years. So this patch really needs to
> update that script to follow the move.
Ah, yes, my bad, will fix.
> As far as I can tell, that's the only reference to logo.gif in the
> entire tree. It makes me wonder if we need it at all. Digging through
> the history suggests it was added in 2.1.15, but never really used for
> anything. It's only role would appear to be to serve as testing
> material for the SPDX checker..:)
If you mean removing the GIF one to replace it with the vector one, I
can send it that way too.
If you mean removing the logo from the tree, then I think it would be
useful to have it available in some other stable URL (so that people
can still fetch it for other purposes), e.g. at kernel.org (not sure
if there is such a place; in both kernel.org and LF's pages there is
just a mention). One potential use case for the logo is to use it
instead of the Rust logo in the Rust docs if the Rust support gets
merged (i.e. instead of the custom one).
At least I hope the Tasmanian devil got a bit of help thanks to the logo! :)
Cheers,
Miguel