2022-05-10 17:10:27

by Charles Keepax

Subject: Re: [PATCH 1/6] ASoC: cs42l52: Fix the error handling of cs42l56_i2c_probe()

On Tue, May 10, 2022 at 11:32:46PM +0800, Zheyu Ma wrote:
> The driver should goto label 'err_enable' when failing at regmap_read().
>
> Signed-off-by: Zheyu Ma <[email protected]>
> ---
> sound/soc/codecs/cs42l56.c | 2 +-

Patch looks good but the subject line says cs42l52 instead of 56.

Thanks,
Charles

2022-05-11 09:52:53

by Zheyu Ma

Subject: [PATCH v2] ASoC: cs42l56: Fix the error handling of cs42l56_i2c_probe()

The driver should goto label 'err_enable' when failing at regmap_read().

Signed-off-by: Zheyu Ma <[email protected]>
---
Changes in v2:
- Fix the typo in the subject
---
sound/soc/codecs/cs42l56.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
index 2c4e09b43199..dc23007336c5 100644
--- a/sound/soc/codecs/cs42l56.c
+++ b/sound/soc/codecs/cs42l56.c
@@ -1245,7 +1245,7 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client)
ret = regmap_read(cs42l56->regmap, CS42L56_CHIP_ID_1, &reg);
if (ret) {
dev_err(&i2c_client->dev, "Failed to read chip ID: %d\n", ret);
- return ret;
+ goto err_enable;
}

devid = reg & CS42L56_CHIP_ID_MASK;
--
2.25.1