2022-05-12 22:18:13

by Jiapeng Chong

Subject: [PATCH v2] net: ethernet: Use swap() instead of open coding it

Clean the following coccicheck warning:

./drivers/net/ethernet/sunplus/spl2sw_driver.c:217:27-28: WARNING
opportunity for swap().

./drivers/net/ethernet/sunplus/spl2sw_driver.c:222:27-28: WARNING
opportunity for swap().

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
-Delete useless comments.

drivers/net/ethernet/sunplus/spl2sw_driver.c | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
index 8320fa833d3e..1cb7076f946d 100644
--- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -204,28 +204,16 @@ static const struct net_device_ops netdev_ops = {

static void spl2sw_check_mac_vendor_id_and_convert(u8 *mac_addr)
{
- u8 tmp;
-
/* Byte order of MAC address of some samples are reversed.
* Check vendor id and convert byte order if it is wrong.
* OUI of Sunplus: fc:4b:bc
*/
if (mac_addr[5] == 0xfc && mac_addr[4] == 0x4b && mac_addr[3] == 0xbc &&
(mac_addr[0] != 0xfc || mac_addr[1] != 0x4b || mac_addr[2] != 0xbc)) {
- /* Swap mac_addr[0] and mac_addr[5] */
- tmp = mac_addr[0];
- mac_addr[0] = mac_addr[5];
- mac_addr[5] = tmp;
-
- /* Swap mac_addr[1] and mac_addr[4] */
- tmp = mac_addr[1];
- mac_addr[1] = mac_addr[4];
- mac_addr[4] = tmp;
-
- /* Swap mac_addr[2] and mac_addr[3] */
- tmp = mac_addr[2];
- mac_addr[2] = mac_addr[3];
- mac_addr[3] = tmp;
+
+ swap(mac_addr[0], mac_addr[5]);
+ swap(mac_addr[1], mac_addr[4]);
+ swap(mac_addr[2], mac_addr[3]);
}
}

--
2.20.1.7.g153144c

2022-05-13 13:50:34

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net: ethernet: Use swap() instead of open coding it

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Thu, 12 May 2022 14:09:05 +0800 you wrote:
> Clean the following coccicheck warning:
>
> ./drivers/net/ethernet/sunplus/spl2sw_driver.c:217:27-28: WARNING
> opportunity for swap().
>
> ./drivers/net/ethernet/sunplus/spl2sw_driver.c:222:27-28: WARNING
> opportunity for swap().
>
> [...]

Here is the summary with links:
- [v2] net: ethernet: Use swap() instead of open coding it
https://git.kernel.org/netdev/net-next/c/a19cef450bb6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html