2022-05-12 16:04:53

by Guangbin Huang

Subject: [PATCH net-next] net: page_pool: add page allocation stats for two fast page allocate path

From: Jie Wang <[email protected]>

Currently If use page pool allocation stats to analysis a RX performance
degradation problem. These stats only count for pages allocate from
page_pool_alloc_pages. But nic drivers such as hns3 use
page_pool_dev_alloc_frag to allocate pages, so page stats in this API
should also be counted.

Signed-off-by: Jie Wang <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>
---
net/core/page_pool.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index bdbadfaee867..f18e6e771993 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -704,8 +704,10 @@ struct page *page_pool_alloc_frag(struct page_pool *pool,

if (page && *offset + size > max_size) {
page = page_pool_drain_frag(pool, page);
- if (page)
+ if (page) {
+ alloc_stat_inc(pool, fast);
goto frag_reset;
+ }
}

if (!page) {
@@ -727,6 +729,7 @@ struct page *page_pool_alloc_frag(struct page_pool *pool,

pool->frag_users++;
pool->frag_offset = *offset + size;
+ alloc_stat_inc(pool, fast);
return page;
}
EXPORT_SYMBOL(page_pool_alloc_frag);
--
2.33.0

2022-05-14 03:50:48

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: page_pool: add page allocation stats for two fast page allocate path

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Thu, 12 May 2022 14:56:31 +0800 you wrote:
> From: Jie Wang <[email protected]>
>
> Currently If use page pool allocation stats to analysis a RX performance
> degradation problem. These stats only count for pages allocate from
> page_pool_alloc_pages. But nic drivers such as hns3 use
> page_pool_dev_alloc_frag to allocate pages, so page stats in this API
> should also be counted.
>
> [...]

Here is the summary with links:
- [net-next] net: page_pool: add page allocation stats for two fast page allocate path
https://git.kernel.org/netdev/net-next/c/0f6deac3a079

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html