2022-05-12 18:24:20

by Alexandre Bailon

[permalink] [raw]
Subject: [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller

This patch adds binding document for mt8195 thermal controller.

Signed-off-by: Alexandre Bailon <[email protected]>
---
.../devicetree/bindings/thermal/mediatek-thermal-lvts.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
index 69ffe7b14c21..2e1ae00d4fd1 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
@@ -12,7 +12,11 @@ maintainers:

properties:
compatible:
- const: mediatek,mt6873-lvts
+ oneOf:
+ - items:
+ - enum:
+ - mediatek,mt6873-lvts
+ - mediatek,mt8195-lvts

reg:
maxItems: 1
--
2.35.1



2022-05-13 11:49:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller

On 12/05/2022 14:24, Alexandre Bailon wrote:
> This patch adds binding document for mt8195 thermal controller.

You just added this binding, no need to change it. Squash it with first
patch.

>
> Signed-off-by: Alexandre Bailon <[email protected]>
> ---
> .../devicetree/bindings/thermal/mediatek-thermal-lvts.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> index 69ffe7b14c21..2e1ae00d4fd1 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: mediatek,mt6873-lvts
> + oneOf:

Why oneOf? There is just one item below?

> + - items:

No items, you have only one item.

> + - enum:
> + - mediatek,mt6873-lvts
> + - mediatek,mt8195-lvts



Best regards,
Krzysztof