2022-05-09 13:59:54

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] mtd: nand: MTD_NAND_ECC_MEDIATEK should depend on ARCH_MEDIATEK

The MediaTek Hardware ECC Engine is only present on MediaTek MT27xx and
MT76xx SoCs. The driver for this engine is a dependency for the
MediaTek NAND controller (MTD_NAND_MTK) and the MediaTek SPI NAND Flash
Interface (SPI_MTK_SNFI) drivers, both of which already depend on
ARCH_MEDIATEK.

Hence add a dependency on ARCH_MEDIATEK to the Hardware ECC Engine
driver, too, to prevent asking the user about this driver when
configuring a kernel without MediaTek SoC support.

Fixes: 4fd62f15afa0d0da ("mtd: nand: make mtk_ecc.c a separated module")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/mtd/nand/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 2f3e02ab72ede6fa..5b0c2c95f10cb8ca 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -56,6 +56,7 @@ config MTD_NAND_ECC_MXIC
config MTD_NAND_ECC_MEDIATEK
tristate "Mediatek hardware ECC engine"
depends on HAS_IOMEM
+ depends on ARCH_MEDIATEK || COMPILE_TEST
select MTD_NAND_ECC
help
This enables support for the hardware ECC engine from Mediatek.
--
2.25.1



2022-05-14 02:32:48

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] mtd: nand: MTD_NAND_ECC_MEDIATEK should depend on ARCH_MEDIATEK

On Mon, 2022-05-09 at 13:50:02 UTC, Geert Uytterhoeven wrote:
> The MediaTek Hardware ECC Engine is only present on MediaTek MT27xx and
> MT76xx SoCs. The driver for this engine is a dependency for the
> MediaTek NAND controller (MTD_NAND_MTK) and the MediaTek SPI NAND Flash
> Interface (SPI_MTK_SNFI) drivers, both of which already depend on
> ARCH_MEDIATEK.
>
> Hence add a dependency on ARCH_MEDIATEK to the Hardware ECC Engine
> driver, too, to prevent asking the user about this driver when
> configuring a kernel without MediaTek SoC support.
>
> Fixes: 4fd62f15afa0d0da ("mtd: nand: make mtk_ecc.c a separated module")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel