2022-05-12 10:02:42

by Zheng Bin

Subject: [PATCH -next] octeon_ep: add missing destroy_workqueue in octep_init_module

octep_init_module misses destroy_workqueue in error path,
this patch fixes that.

Signed-off-by: Zheng Bin <[email protected]>
---
drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
index e020c81f3455..ebf78f6ca82b 100644
--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
@@ -1149,6 +1149,7 @@ static int __init octep_init_module(void)
if (ret < 0) {
pr_err("%s: Failed to register PCI driver; err=%d\n",
OCTEP_DRV_NAME, ret);
+ destroy_workqueue(octep_wq);
return ret;
}

--
2.31.1

2022-05-13 22:00:49

by Jakub Kicinski

Subject: Re: [PATCH -next] octeon_ep: add missing destroy_workqueue in octep_init_module

On Thu, 12 May 2022 17:38:37 +0800 Zheng Bin wrote:
> octep_init_module misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <[email protected]>

Also missing a Fixes tag.