2022-05-13 09:41:59

by Markuss Broks

[permalink] [raw]
Subject: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties

This patch adds the optional properties for the VL53L0X ToF sensor to the
device-tree binding.

Signed-off-by: Markuss Broks <[email protected]>
---
.../devicetree/bindings/iio/proximity/st,vl53l0x.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml b/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
index 656460d9d8c8..322befc41de6 100644
--- a/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
@@ -19,6 +19,11 @@ properties:
interrupts:
maxItems: 1

+ reset-gpios:
+ maxItems: 1
+
+ vdd-supply: true
+
required:
- compatible
- reg
--
2.36.1



2022-05-14 01:07:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties

On 12/05/2022 21:13, Markuss Broks wrote:
> This patch adds the optional properties for the VL53L0X ToF sensor to the
> device-tree binding.
>
> Signed-off-by: Markuss Broks <[email protected]>

Wait, two days and three versions? Please give some time before
resending entire patchset.

Same comments apply as for v2 and v3...


Best regards,
Krzysztof

2022-05-15 09:46:58

by Markuss Broks

[permalink] [raw]
Subject: Re: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties

Hi Jonathan,

On 5/14/22 17:29, Jonathan Cameron wrote:
> On Fri, 13 May 2022 10:56:50 +0200
> Krzysztof Kozlowski <[email protected]> wrote:
>
>> On 12/05/2022 21:13, Markuss Broks wrote:
>>> This patch adds the optional properties for the VL53L0X ToF sensor to the
>>> device-tree binding.
>>>
>>> Signed-off-by: Markuss Broks <[email protected]>
>> Wait, two days and three versions? Please give some time before
>> resending entire patchset.
> Yeah, several instances of this on the IIO list this week. Please
> let things sit for at least a few days between versions even if
> the requested changes are fairly minor.
>
>> Same comments apply as for v2 and v3...
>>
> I 'could' fix this up, but given you've not responded to Krzysztof
> I think I'd prefer you send a v5 in the second half of next week or
> later (to give time for other review) with the patch description
> change Krzysztof suggested made.
OK, good. I will give this version some time to settle and send a
version with those fixes some time next week.
>
> Code wise the series looks fine to me.
>
> Jonathan
>
>
>
>> Best regards,
>> Krzysztof
- Markuss

2022-05-15 20:03:24

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties

On Fri, 13 May 2022 10:56:50 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> On 12/05/2022 21:13, Markuss Broks wrote:
> > This patch adds the optional properties for the VL53L0X ToF sensor to the
> > device-tree binding.
> >
> > Signed-off-by: Markuss Broks <[email protected]>
>
> Wait, two days and three versions? Please give some time before
> resending entire patchset.

Yeah, several instances of this on the IIO list this week. Please
let things sit for at least a few days between versions even if
the requested changes are fairly minor.

>
> Same comments apply as for v2 and v3...
>
I 'could' fix this up, but given you've not responded to Krzysztof
I think I'd prefer you send a v5 in the second half of next week or
later (to give time for other review) with the patch description
change Krzysztof suggested made.

Code wise the series looks fine to me.

Jonathan



>
> Best regards,
> Krzysztof