This patch series aim to add Aspeed USB 2.0 Device Controller (udc)
driver, including driver itself, device tree node and documentation.
*** BLURB HERE ***
Neal Liu (3):
usb: gadget: add Aspeed ast2600 udc driver
ARM: dts: aspeed: Add USB2.0 device controller node
dt-bindings: usb: add documentation for aspeed udc
.../devicetree/bindings/usb/aspeed,udc.yaml | 52 +
MAINTAINERS | 7 +
arch/arm/boot/dts/aspeed-g6.dtsi | 10 +
drivers/usb/gadget/udc/Kconfig | 13 +
drivers/usb/gadget/udc/Makefile | 1 +
drivers/usb/gadget/udc/aspeed_udc.c | 1594 +++++++++++++++++
6 files changed, 1677 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml
create mode 100644 drivers/usb/gadget/udc/aspeed_udc.c
--
2.25.1
Add device tree binding documentation for the Aspeed USB2.0 Device
Controller.
Signed-off-by: Neal Liu <[email protected]>
---
.../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml
diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml
new file mode 100644
index 000000000000..d1d2f77d1c54
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2020 Facebook Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASPEED USB 2.0 Device Controller
+
+maintainers:
+ - Neal Liu <[email protected]>
+
+description: |+
+ The ASPEED USB 2.0 Device Controller implements 1 control endpoint and
+ 4 generic endpoints for AST260x.
+
+ Supports independent DMA channel for each generic endpoint.
+ Supports 32/256 stages descriptor mode for all generic endpoints.
+
+properties:
+ compatible:
+ enum:
+ - aspeed,ast2600-udc
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/aspeed-clock.h>
+ udc: udc@1e6a2000 {
+ compatible = "aspeed,ast2600-udc";
+ reg = <0x1e6a2000 0x300>;
+ interrupts = <9>;
+ clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb2bd_default>;
+ };
--
2.25.1
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Monday, May 16, 2022 1:54 PM
> To: Neal Liu <[email protected]>; Greg Kroah-Hartman
> <[email protected]>; Rob Herring <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Joel Stanley <[email protected]>;
> Andrew Jeffery <[email protected]>; Felipe Balbi <[email protected]>; Sumit
> Semwal <[email protected]>; Christian König
> <[email protected]>; Geert Uytterhoeven <[email protected]>;
> Li Yang <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc
>
> On 16/05/2022 03:59, Neal Liu wrote:
> >>> Okay, I could rename it for next patch if you preferred.
> >>> But there are lots of yaml files which are not named as first compatible.
> >>
> >> Yes, I know, I quite likely I also produced such bindings, but a
> >> specific name is rather preferred. Otherwise you will have a
> >> difficult naming choice when your next Aspeed UDC requires new
> >> bindings file because of some differences (not yet known now).
> >>
> > We can rename the bindings if next Aspeed UDC needs, don't you think?
> > Currently, Aspeed has no requirement.
>
> So just use proper name from the beginning....
>
Okay, I'll rename it for next patch.
Thanks for the review.
>
> Best regards,
> Krzysztof