2022-05-14 01:34:13

by Bjorn Andersson

Subject: [PATCH 1/3] dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB3 UNI phy

The SC8280XP platform has a pair of 5nm USB3 UNI phys, add a compatible
for these.

Signed-off-by: Bjorn Andersson <[email protected]>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 8b850c5ab116..0a9ee5b7600d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -33,6 +33,7 @@ properties:
- qcom,sc8180x-qmp-ufs-phy
- qcom,sc8180x-qmp-usb3-phy
- qcom,sc8280xp-qmp-ufs-phy
+ - qcom,sc8280xp-qmp-usb3-uni-phy
- qcom,sdm845-qhp-pcie-phy
- qcom,sdm845-qmp-pcie-phy
- qcom,sdm845-qmp-ufs-phy
--
2.35.1

2022-05-17 02:04:18

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB3 UNI phy

On 14/05/2022 00:53, Bjorn Andersson wrote:
> The SC8280XP platform has a pair of 5nm USB3 UNI phys, add a compatible
> for these.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 8b850c5ab116..0a9ee5b7600d 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -33,6 +33,7 @@ properties:
> - qcom,sc8180x-qmp-ufs-phy
> - qcom,sc8180x-qmp-usb3-phy
> - qcom,sc8280xp-qmp-ufs-phy
> + - qcom,sc8280xp-qmp-usb3-uni-phy

What about the clocks/resets/supplies in allOf:if:then?


Best regards,
Krzysztof

2022-05-17 02:10:45

by Bjorn Andersson

Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB3 UNI phy

On Mon 16 May 00:11 PDT 2022, Krzysztof Kozlowski wrote:

> On 14/05/2022 00:53, Bjorn Andersson wrote:
> > The SC8280XP platform has a pair of 5nm USB3 UNI phys, add a compatible
> > for these.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
> > ---
> > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > index 8b850c5ab116..0a9ee5b7600d 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > @@ -33,6 +33,7 @@ properties:
> > - qcom,sc8180x-qmp-ufs-phy
> > - qcom,sc8180x-qmp-usb3-phy
> > - qcom,sc8280xp-qmp-ufs-phy
> > + - qcom,sc8280xp-qmp-usb3-uni-phy
>
> What about the clocks/resets/supplies in allOf:if:then?
>

Of course, seems like I missed that part.

Thanks,
Bjorn